Watch directory downloads should not require user interaction

[Patrick O'Callaghan]

When using a watch directory (i.e. automatic download directory) qBT will pause for user interaction if the option to present a dialogue on every download is set. This is inconvenient when torrents are placed in the watch directory by another program such as Ted (The Episode Downloader), and frequently means the torrent is not downloaded until the user notices the presence of the torrent file and manually opens it from within qBT.

This was reported as a bug in the inotify mechanism: https://bugs.launchpad.net/qbittorrent/+bug/435908 but experimentation shows it seems not to be the case.

Proposal: I think there needs to be a distinction between a) user calling qBT by clicking on a torrent link, say in a web page, and b) fully automatic downloading via the watch directory mechanism. There should be separate options in each case, or failing that the existing option dialogue should apply only to case (a) and not to case (b).

[Christophe Dumez (hydr0g3n)]

Thanks. I believe you are right. I'll fix this when I come back from vacation :)

[Christophe Dumez (hydr0g3n)]

Hi, I have just came back from vacation.

I have tried to reproduce your issue but it works fine here. Torrents added by folder scanning do not display the torrent addition dialog. Which Operating System are you using?

[Christophe Dumez (hydr0g3n)]

I have rechecked my code and I use a different torrent addition function for torrents issued by the folder watching mechanism. I am confident that it does not require user interaction on any operating system. Are you certain?

[Patrick O'Callaghan (pocallaghan)]

On Fri, Aug 13, 2010 at 9:49 AM, Christophe Dumez <email address hidden>wrote:

> I have rechecked my code and I use a different torrent addition function
> for torrents issued by the folder watching mechanism. I am confident
> that it does not require user interaction on any operating system. Are
> you certain?

I am certain that I have the problem, i.e. that torrent files placed in the
watch directory may or may not be downloaded and this appears to be random.
This has been going on for several months. I thought the problem might be
related to the dialogue options but it's not (as you say). I'm using version
2.3.0 under Fedora 13 (64-bit but that shouldn't matter). I've tested the
inotify function locally using inotifywait in the watch directory and it
works correctly.

I don't know what else I can test.

poc

[Patrick O'Callaghan (pocallaghan)]

On Fri, Aug 13, 2010 at 10:07 AM, Patrick O'Callaghan <<email address hidden>
> wrote:

> On Fri, Aug 13, 2010 at 9:49 AM, Christophe Dumez <email address hidden>wrote:
>
>> I have rechecked my code and I use a different torrent addition function
>> for torrents issued by the folder watching mechanism. I am confident
>> that it does not require user interaction on any operating system. Are
>> you certain?
>
>
> I am certain that I have the problem, i.e. that torrent files placed in the
> watch directory may or may not be downloaded and this appears to be random.
> This has been going on for several months. I thought the problem might be
> related to the dialogue options but it's not (as you say). I'm using version
> 2.3.0 under Fedora 13 (64-bit but that shouldn't matter). I've tested the
> inotify function locally using inotifywait in the watch directory and it
> works correctly.
>
> I don't know what else I can test.
>

(This should probably be on a different thread, but anyway ...)

It would be helpful if the logs distinguished between manually and
automatically added torrents. That way I might be able to reconstruct the
history more accurately. Also, is there a way to see logs from previous
sessions? The only log I see is from the current session.

poc