'Remember choice' button in delete dialog doesn't work

[Timmmm]

Steps to recreate.

1. Install qBittorrent
2. Open torrent.
3. Right-click->delete
4. Play around with the 'delete from disk' check box. The padlock button (remember choice) will be enabled and disabled. It's really confusing and I don't see why it should ever be disabled - you can surely remember any choice?

[Christophe Dumez (hydr0g3n)]

The button is disabled when the current state is the one that is currently locked (remembered). Why Enable it under these circumstances since it won't change anything?

[Timmmm (tdhutt)]

Ah I kind of see what you mean. But I think it is confusing still (obviously I find it confusing, and I'm not exactly a novice!)

I'd suggest the following:

1. Change the hover text to 'Set as default choice' rather than 'remember choice'. 'Remember choice' sounds like you won't get the opportunity to change it in future (which is usually the case for 'remember my choice' style dialogs).
2. Change it to a button rather than a toggle. Instead of disabling it when it isn't appropriate, just hide it. Normally I don't think hiding controls is a good idea, but in this case I think it makes sense. Also when you click it it should depress, and the disappear half a second later (maybe with a pop-up type thing saying 'default set' or something).