deployment report should fail revisions in stable containing undeployed db changes

Bug #845464 reported by Stuart Bishop
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
High
Unassigned
qa-tagger
Triaged
High
Unassigned

Bug Description

A revision in launchpad/stable should be flagged as bad if it contains database changes that have not previously landed in launchpad/db-stable.

'database changes' means any change to database/schema/*.sql, including addition or removal of files matching this pattern.

Revision history for this message
Stuart Bishop (stub) wrote :

Once this is done, the losas can remove the PQM guard blocking database landings on launchpad/devel. This will allow devs to merge db-devel into devel rather than requiring losas to do it.

Changed in launchpad:
status: New → Triaged
importance: Undecided → High
tags: added: fastdowntime-later
Stuart Bishop (stub)
summary: - daployment report should fail revisions in stable containing undeployed
+ deployment report should fail revisions in stable containing undeployed
db changes
Changed in qa-tagger:
status: New → Triaged
importance: Undecided → High
Revision history for this message
Stuart Bishop (stub) wrote :

I'm not sure if this logic is right. We don't care if db changes have previously landed in db-stable. We care that they have been deployed.

Revision history for this message
Stuart Bishop (stub) wrote :

db patch to store bzr revisions used to make updates has landed. Next up, patches to update.py to maintain these fields.

Once we have the information available in the database, we can export it (probably as a json blob served from launchpad.net).

Then the qatagger has the information it needs to determine what should and shouldn't be merged.

Revision history for this message
Stuart Bishop (stub) wrote :

The data is in the database in the LaunchpadDatabaseRevision and LaunchpadDatabaseUpdateLog

Revision history for this message
Stuart Bishop (stub) wrote :

Ignore LaunchpadDatabaseUpdateLog - it will be disappearing. It is only needed to track non-db patch changes like stuff altered in trusted.sql and we are stopping doing that.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.