attach_disconnected test from test_regression_testsuite of ubuntu_qrt_apparmor failed with "Unable to run test sub-executable" on Mantic

[Po-Hsu Lin]

Issue found on Mantic since 6.5.0-11.11

Test failed with:
  running attach_disconnected
  Fatal Error (unix_fd_server): Unable to run test sub-executable

By hacking the tests/regression/apparmor/prologue.inc:
diff --git a/prologue.inc.orig b/prologue.inc
index 9da05f2..fafc244 100755
--- a/prologue.inc.orig
+++ b/prologue.inc
@@ -297,7 +297,9 @@ checktestfg()
 {
        # global _pfmode _known _testdesc outfile teststatus testname
        local ret expectedsig killedsig
+ echo "==== $outfile ==="
        ret=`cat $outfile 2>/dev/null`
+ echo "$ret"
        teststatus=pass

        case "$ret" in

Run tests/regression/apparmor/attach_disconnected.sh manually, you will find the test is failing because the second test generates "PASS" twice (it's not appending the result to the $outfile as we are using "$testexec "$@" > $outfile 2>&1 &" in runtestfg():

$ sudo bash attach_disconnected.sh
==== /tmp/sdtest.345049-12729-P0mta1/output.unix_fd_server ===
PASS
==== /tmp/sdtest.345049-12729-P0mta1/output.unix_fd_server ===
PASS
PASS
Fatal Error (unix_fd_server): Unable to run test sub-executable

The $ret become 'PASS\nPASS' and consequently falls in the case of testerror:
  *) testerror
          return
          ;;

[Po-Hsu Lin (cypressyew)]

One interesting finding is that if you run the test directly, it will just print "PASS"

$ sudo /tmp/testlib_4jpn6z_/source/mantic/apparmor-4.0.0~alpha2/tests/regression/apparmor/unix_fd_server /tmp/sdtest.346048-11072-CHR92J/file /tmp/testlib_4jpn6z_/source/mantic/apparmor-4.0.0~alpha2/tests/regression/apparmor/attach_disconnected /tmp/sdtest.346048-11072-CHR92J/unix_fd_test /dev/loop6 /tmp/sdtest.346048-11072-CHR92J/new_root/ /tmp/sdtest.346048-11072-CHR92J/new_root/put_old/
PASS

But if you redirect it into a file, you will see PASS twice:
$ sudo /tmp/testlib_4jpn6z_/source/mantic/apparmor-4.0.0~alpha2/tests/regression/apparmor/unix_fd_server /tmp/sdtest.346048-11072-CHR92J/file /tmp/testlib_4jpn6z_/source/mantic/apparmor-4.0.0~alpha2/tests/regression/apparmor/attach_disconnected /tmp/sdtest.346048-11072-CHR92J/unix_fd_test /dev/loop6 /tmp/sdtest.346048-11072-CHR92J/new_root/ /tmp/sdtest.346048-11072-CHR92J/new_root/put_old/ > /tmp/a
$ cat /tmp/a
PASS
PASS

I am not sure why this is happening for the moment.

[Georgia Garcia (georgiag)]

Hello!

Thanks for reporting! I fixed this issue upstream, commit https://gitlab.com/apparmor/apparmor/-/commit/dc73f0fc0b81a70e71899592f9969026f450420c
I'll add it to the QA Regression Tests.

[Georgia Garcia (georgiag)]

Should be fixed by https://code.launchpad.net/~georgiag/qa-regression-testing/+git/qa-regression-testing/+merge/459835
Thanks!

[Bethany Jamison (bjamison)]

Similar 'running attach_disconnected' failure with Mantic lowlatency s2024.01.8

(http://10.246.75.167/s2024.01.08/mantic/linux-lowlatency/6.5.0-21.21.1/sru-lowlatency-azure-Standard_A2_v2-ubuntu_qrt_apparmor-log.html#ApparmorTestsuites.test_regression_testsuite-start)