Failed to build test_old_trusty_regression_testsuite on Trusty ARM64

[Po-Hsu Lin]

The test_old_trusty_regression_testsuite from the ubuntu_qrt_apparmor will fail.

Error message:
cc -Wall -Wstrict-prototypes openat.c -lapparmor -o openat
cc -Wall -Wstrict-prototypes pipe.c -lapparmor -o pipe
cc -Wall -Wstrict-prototypes ptrace.c -lapparmor -o ptrace
ptrace.c: In function ‘do_parent’:
ptrace.c:40:14: error: storage size of ‘regs’ isn’t known
struct user regs;
^
ptrace.c:92:14: error: ‘PTRACE_GETREGS’ undeclared (first use in this function)
if (ptrace(PTRACE_GETREGS, pid, NULL, ®s) == -1) {
^
ptrace.c:92:14: note: each undeclared identifier is reported only once for each function it appears in
ptrace.c:40:14: warning: unused variable ‘regs’ [-Wunused-variable]
struct user regs;
^
make: *** [ptrace] Error 1

complete output: http://pastebin.ubuntu.com/24931001/

[Tyler Hicks (tyhicks)]

The ptrace.c file contains both of these includes:

#include <sys/ptrace.h>
...
#include <sys/user.h>

Those header files should provide the definitions that are missing in your build failure. Can you ensure that you have linux-libc-dev and libc6-dev installed?

[Po-Hsu Lin (cypressyew)]

Hello,

yes these two packages are installed on the system

$ dpkg -l | grep -e libc6-dev -e linux-libc-dev
ii libc6-dev:arm64 2.19-0ubuntu6.13 arm64 Embedded GNU C Library: Development Libraries and Header Files
ii linux-libc-dev:arm64 3.13.0-121.170 arm64 Linux Kernel Headers for development

[Tyler Hicks (tyhicks)]

Thanks - It must be something specific to the arm64 environment that's a little off in regards to the header files that need to be included.

[Sean Feole (sfeole)]

Sam, Tyler, is this still something that needs to be chased down?

 very old bug, with no action on it, marking bug as incomplete and will close in 5 days if no update.

[Po-Hsu Lin (cypressyew)]

This issue is still valid.
http://10.246.72.4/test-results/3.13.0-158.208-generic/ms10-35-mcdivittB0-kernel__3.13.0-158.208__2018-08-28_04-11-00/ubuntu_qrt_apparmor/results/ubuntu_qrt_apparmor.test-apparmor.py/debug/ubuntu_qrt_apparmor.test-apparmor.py.DEBUG.html

[Steve Beattie (sbeattie)]

Hi Po-Hsu, I spent some time looking into this, and it looks like when the old apparmor tests got split out for trusty, one of the patches that needed to be applied to the regression test suite got dropped ('tests-convert_ptrace_getregset.patch'). I have committed a fix to qrt to re-apply this patch for the old apparmor source on trusty (it is already in the updated apparmor trusty source) in https://git.launchpad.net/qa-regression-testing/commit/?id=792e09115c319cf04839f0c4b2b7d43d018b5bcf .

There is another possible fix that may need to be applied, so please re-open if you end up running this test on arm64 again and it fails. Thanks.

[Po-Hsu Lin (cypressyew)]

Hi Steve,

the error message chagned from:
    ptrace.c:92:14: error: ‘PTRACE_GETREGS’ undeclared (first use in this function)

To:
    readdir.c:45:14: error: ‘SYS_getdents’ undeclared (first use in this function)

Looks like we need more patches for that.
Thanks.

[Po-Hsu Lin (cypressyew)]

https://pastebin.ubuntu.com/p/Q64rNYbBGX/ Full result for the ARM64 test in this cycle.

[Steve Beattie (sbeattie)]

Ah, the old apparmor version tests were also missing the test fix for the getdents syscall not being supported on arm64, only getdents64. This has been fixed in https://git.launchpad.net/qa-regression-testing/commit/?id=8203725a3933bb3fa9f957a309b287d070bfbe9e .

Po-Hsu, I think that's all the fixups that are specific to arm64. If you could re-run the kernel tests for arm64/trusty, that would be great to confirm.

Thanks!

[Po-Hsu Lin (cypressyew)]

Thanks for the fix Steve,
the ubuntu-qrt-apparmor is now marked as passed for Trusty ARM64.

I will close this bug.