dashboard testuite showing too many test-cases

[Andy Doan]

To put this in context of our code:
  SmokeResult = testsuite
  SmokeTestResult = test-case

Paul noticed a situation where we were showing too many SmokeTestResults when view a SmokeResult today:

 http://ci.ubuntu.com/smokeng/trusty/touch/maguro/176:20140212:20140115.1/6553/music_app/

The phablet-test run result was actually from jenkins job 14. In job 14 the music app failed completed which caused a "phablet-test-run" failure to be created. The job was then re-run (job 15) and results were produced. The problem is that our phablet-test-run SmokeTestResult remained.

I believe the issue is that we re-use the SmokeResult object when we do re-runs on an image. I think this means we need to delete all the SmokeTestResult objects contained by a SmokeResult object when this happens. I *think* this means the fix needs to happen in one or two places:

1) at the api.py level when we "queue" the SmokeResult
2)(probably optional but can't hurt): After doing the "get_or_create" for a SmokeResult in the pull-script we should probably clean things up.

On the bright-side - I think this is something I can create some test-cases for while doing the patch.