Comment 4 for bug 1247664

Revision history for this message
brianclements (brianclements) wrote : Re: [Bug 1247664] Re: Pythoscope should follow PEP8 layout guidelines for generated files

Finally got around to it!
https://github.com/mkwiatkowski/pythoscope/pull/2

Let me know if I broke anything there, I'm still pretty new to this :D

Brian Clements
<email address hidden>
http://brianclements.net <http://www.brianclements.net>

On Fri, Nov 8, 2013 at 3:13 AM, Michal Kwiatkowski <email address hidden> wrote:

> Wow, for some reason I thought it should be the other way around. But
> you can't argue with pep8. ;)
>
> I don't have time at the moment to fix this, but would gladly accept a
> pull request.
>
> Two lines separating imports from the rest of the code can be fixed
> here:
>
> https://github.com/mkwiatkowski/pythoscope/blob/master/pythoscope/generator/adder.py#L105
>
> while inline comments can be fixed here:
>
> https://github.com/mkwiatkowski/pythoscope/blob/d0f57da53f01004dc82efbd0bf9e0d3f04e63cb1/pythoscope/generator/builder.py#L33
>
> Tests and docs should be updated as well.
>
> ** Changed in: pythoscope
> Status: Incomplete => Confirmed
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1247664
>
> Title:
> Pythoscope should follow PEP8 layout guidelines for generated files
>
> Status in Pythoscope, the unit test generator:
> Confirmed
>
> Bug description:
> For those of us with automatic file checkers and the like, having to
> clean up and reformat many many functions in the automatically
> generated test files that fail to meet the PEP8 guidelines seems
> unnecessary. I'm specifically referring to:
>
> 1) 2 blank lines in before top level functions and classes, and imports
> and the rest of the file
> 2) 2 blank spaces before in-line comments
>
> There might be others but so far this is all I've found.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/pythoscope/+bug/1247664/+subscriptions
>