lintian check of python-zvm-skd and zthin debian package failed with errors

[[e-mail]]

when use lintian to check the python-zvm-sdk and zthin debian packages on Ubuntu, got following errors and warnings. We need to at least resolve these errors.

root@gpok163:~# lintian python-zvm-sdk_1.0.1_all.deb
warning: the authors of lintian do not recommend running it with root privileges!
E: python-zvm-sdk: debian-changelog-file-contains-invalid-email-address jichen@unknown
E: python-zvm-sdk: debian-changelog-file-contains-invalid-email-address jichen@unknown
W: python-zvm-sdk: copyright-without-copyright-notice
W: python-zvm-sdk: description-starts-with-leading-spaces
E: python-zvm-sdk: maintainer-address-malformed jichenjc <email address hidden> huangrui <email address hidden>
W: python-zvm-sdk: wrong-section-according-to-package-name python-zvm-sdk => python
W: python-zvm-sdk: zero-byte-file-in-doc-directory usr/share/doc/python-zvm-sdk/copyright
W: python-zvm-sdk: file-in-unusual-dir var/opt/zvmsdk/zvmsdklogs
W: python-zvm-sdk: binary-without-manpage usr/bin/gen-token
W: python-zvm-sdk: binary-without-manpage usr/bin/sdkserver
W: python-zvm-sdk: binary-without-manpage usr/bin/zvmsdk-wsgi
W: python-zvm-sdk: command-with-path-in-maintainer-script postinst:5 /usr/bin/getent
W: python-zvm-sdk: command-with-path-in-maintainer-script postrm:6 /usr/bin/getent
E: python-zvm-sdk: systemd-service-file-outside-lib usr/lib/systemd/system/sdkserver.service
W: python-zvm-sdk: systemd-service-file-refers-to-obsolete-target usr/lib/systemd/system/sdkserver.service syslog.target

root@gpok163:~# lintian zthin_3.1.1_s390x.deb
warning: the authors of lintian do not recommend running it with root privileges!
W: zthin: missing-depends-line
W: zthin: wrong-bug-number-in-closes l10:#nnnn
E: zthin: debian-changelog-file-contains-invalid-email-address jichen@unknown
E: zthin: debian-changelog-file-contains-invalid-email-address jichen@unknown
W: zthin: latest-debian-changelog-entry-changed-to-native
W: zthin: copyright-without-copyright-notice
E: zthin: description-starts-with-package-name
W: zthin: description-starts-with-leading-spaces
E: zthin: maintainer-address-malformed jichen <email address hidden> huangrui <email address hidden>
E: zthin: package-modifies-ld.so-search-path etc/ld.so.conf.d/zthin.conf
E: zthin: dir-or-file-in-opt opt/zthin/
E: zthin: dir-or-file-in-opt opt/zthin/bin/
E: zthin: dir-or-file-in-opt opt/zthin/bin/IUCV/
E: zthin: dir-or-file-in-opt ... use --no-tag-display-limit to see all (or pipe to a file/program)
W: zthin: file-in-unusual-dir var/opt/zthin/tracing.conf
W: zthin: file-in-unusual-dir var/opt/zthin/zthinlogs
W: zthin: script-not-executable opt/zthin/bin/IUCV/iucvserd
W: zthin: script-not-executable opt/zthin/bin/IUCV/iucvserverdaemoninstaller.sh
W: zthin: script-not-executable opt/zthin/bin/IUCV/iucvupgrade.sh
W: zthin: script-not-executable ... use --no-tag-display-limit to see all (or pipe to a file/program)
W: zthin: command-with-path-in-maintainer-script postinst:29 /sbin/ldconfig
W: zthin: postinst-has-useless-call-to-ldconfig
W: zthin: maintainer-script-calls-systemctl postinst:24

[[e-mail] (dyyang)]

Some investigation:

1. E: python-zvm-sdk: debian-changelog-file-contains-invalid-email-address jichen@unknown

     This comes from the build-zvmsdk/sdkdeb/changelog:

    -- jichen <jichen@unknown> Tue, 03 Apr 2018 15:43:15 +0800

     Need to update this mail address.

2. E: python-zvm-sdk: maintainer-address-malformed jichenjc <email address hidden> huangrui <email address hidden>

     This comes from build-zvmsdk/sdkdeb/control:

    Maintainer: jichenjc <email address hidden> huangrui <email address hidden>

     Seems only one maintainer and mail address can be specified in the Maintainer field.

3. E: python-zvm-sdk: systemd-service-file-outside-lib usr/lib/systemd/system/sdkserver.service

      This is because we put the sdkserver.service into /usr/lib/systemd/system/, according to the explaination of this error report in https://lintian.debian.org/tags/systemd-service-file-outside-lib.html:

    The package ships a systemd service file outside /lib/systemd/system/

    Systemd in Debian searches for unit files in /lib/systemd/system/ and /etc/systemd/system. Notably, it does not look in /usr/lib/systemd/system/ for service files.

    System administrators should have the possibility to overwrite a service file (or parts of it, in newer systemd versions) by placing a file in /etc/systemd/system, so the canonical location used for service files is /lib/systemd/system/.

    Severity: serious, Certainty: certain

    Check: systemd, Type: binary

    We need to consider move the service file into /lib/systemd/system/.

[jichenjc (jichenjc)]

https://review.gerrithub.io/c/mfcloud/build-zvmsdk/+/435832 and
https://review.gerrithub.io/c/mfcloud/python-zvm-sdk/+/435835

[jichenjc (jichenjc)]

Remove the error output and some warning still there... but very low priority now