No need to keep the GET /guests/{userid}/nic, its functions are covered by the GET /guests/nics

[[e-mail]]

Functions duplicate in the two APIs and confusing:

 GET /guests/{userid}/nic:

get the nic and vswitch pair info from database.

GET /guests/nics:

get all info from database, including userid, nic number, vswitch, nic id and comments.
This API support to filter with a userid specified.

So we need to consider remove the GET /guests/{userid}/nic API which corresponds to guest_get_nic_vswitch_info(self, userid)

[jichenjc (jichenjc)]

I'd argue because sometimes you don't need all info and only want one NIC info, then better to keep both for performance reason?

[Ya Lian Pan (yalian)]

It is not an performance issue, you can use GET /guests/nics?userid=XXX to do the same work as
GET /guests/{XXX}/nic

[Ya Lian Pan (yalian)]

here is the patch
https://review.gerrithub.io/c/mfcloud/python-zvm-sdk/+/412607