source code should be compliant with Import order template

Bug #1533115 reported by David TARDIVEL
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-watcherclient
Wishlist
David TARDIVEL

Bug Description

source code should be compliant with http://docs.openstack.org/developer/hacking/#import-order-template.

For the i18n imports there is an exception on the hacking rules pages (see http://docs.openstack.org/developer/hacking/#imports)
So you actually need to add the following into your tox.ini file
[hacking]
import_exceptions = watcherclient.common._i18n

Changed in python-watcherclient:
importance: Undecided → Wishlist
assignee: nobody → David TARDIVEL (david-tardivel)
milestone: none → mitaka-2
Changed in python-watcherclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-watcherclient (master)

Reviewed: https://review.openstack.org/266274
Committed: https://git.openstack.org/cgit/openstack/python-watcherclient/commit/?id=4b2f948e7a8e83cea474ba790414e4e0b7dc16b9
Submitter: Jenkins
Branch: master

commit 4b2f948e7a8e83cea474ba790414e4e0b7dc16b9
Author: David.T <email address hidden>
Date: Mon Jan 11 21:17:41 2016 +0100

    Respect the import order template

    Package import order shall respect hacking rules defined by
    OpenStack, excepting i18n package import.

    Change-Id: I5d609d0414a5eb270fd27ed16dc0a4630ea35086
    Closes-Bug: #1533115

Changed in python-watcherclient:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers