logging messages should use function parameters instead of string format arguments

Bug #1320926 reported by Christian Berendt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-troveclient
Wishlist
Christian Berendt

Bug Description

There are files containing string format arguments. Using logging function parameters should be preferred.

Affected files:

  * troveclient/client.py
  * troveclient/compat/client.py

Changed in python-troveclient:
assignee: nobody → Christian Berendt (berendt)
status: New → In Progress
Revision history for this message
Nikhil Manchanda (slicknik) wrote :

Can you please add an example of this to the bug? Thanks!

Changed in python-troveclient:
importance: Undecided → Wishlist
Revision history for this message
Amrith Kumar (amrith) wrote :

Why should they? is it wrong to have code as it is currently?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-troveclient (master)

Change abandoned by Nikhil Manchanda (<email address hidden>) on branch: master
Review: https://review.openstack.org/94209
Reason: This patch is being abandoned as part of routine cleanup (patches older than 4 weeks with a negative review).

Please feel free to restore the patch if this is something you're still actively working on.

Thanks!

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers