used vim delete results in "'dict' object has no attribute 'iteritems'"

[Radosław Piliszek]

If vim is still in use and one tries to remove it, then tackerclient goes cryptic:

+ openstack vim delete kolla-sample-vim
'dict' object has no attribute 'iteritems'

Tacker API logs this (hence I know it just was in use):

2020-04-10 14:24:28.882 21 ERROR tacker.api.v1.resource tacker.extensions.nfvo.VimInUseException: VIM 87a4545f-7ff0-4dea-b966-e6ef077e613e is still in use by VNF

I suggest tackerclient handle this situation appropriately.

Branch: master (today, Ussuri)

[Radosław Piliszek (yoctozepto)]

Most likely the issue is in tackerclient itself but I left both as affected.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/727051

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/727057
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=ccf89cb1497b18947557a7db05470314c3481df8
Submitter: Zuul
Branch: master

commit ccf89cb1497b18947557a7db05470314c3481df8
Author: Yasufumi Ogawa <email address hidden>
Date: Tue May 12 05:48:52 2020 +0000

    Cleanup deprecated iteritems of dict

    To fix the issue because of using deprecated method in python3, replace
    iteritems() with items(). Although tacker itself does not cause the
    error because it uses `six` actually, no need to keep python2 support.

    Change-Id: Ifec7d5d3146ffe01addcb1e5c0ab78ce92bae0ff
    Related-Bug: 1872120

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/727051
Committed: https://git.openstack.org/cgit/openstack/python-tackerclient/commit/?id=741fd38741b41624349a7f63b5906704b3e2a752
Submitter: Zuul
Branch: master

commit 741fd38741b41624349a7f63b5906704b3e2a752
Author: Yasufumi Ogawa <email address hidden>
Date: Tue May 12 04:22:49 2020 +0000

    Cleanup deprecated iteritems of dict

    To fix the issue because of using deprecated method in python3, replace
    iteritems() with items().

    Change-Id: If3136a5ba471d2cd7ea9420b599567a2fa532cad
    Partial-Bug: 1872120