on bulk_delete with cli, a 1 is appended at the end of deleted objects names

Bug #1852808 reported by Sébastien BLAISOT
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-swiftclient
Fix Released
Undecided
Sébastien BLAISOT

Bug Description

when deleting multiple objects in a container with swift cli with bulk_delete, deleted objects name are printed with a '1' appended to them.

This is caused some lines forgotten in the code, in this particular if branch (bulk + success):
a = (' [after {0} attempts]'.format(a)
    if a > 1 else '')

Changed in python-swiftclient:
status: New → Confirmed
assignee: nobody → Sébastien BLAISOT (sblaisot)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-swiftclient (master)

Fix proposed to branch: master
Review: https://review.opendev.org/694629

Changed in python-swiftclient:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-swiftclient (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/694635

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-swiftclient (master)

Reviewed: https://review.opendev.org/694629
Committed: https://git.openstack.org/cgit/openstack/python-swiftclient/commit/?id=709ab385c6eb3d3c7b313bc48c959e9ace606ae5
Submitter: Zuul
Branch: master

commit 709ab385c6eb3d3c7b313bc48c959e9ace606ae5
Author: Sébastien Blaisot <email address hidden>
Date: Fri Nov 15 22:37:38 2019 +0100

    Fix printed object names on successful bulk-delete

    Replace the 1 always concatenated to printed object names for each
    successfully deleted object in bulk-delete with an optional [after x
    attempts] if x > 1

    Change-Id: If4af9141fe4f3436a4e9e0e2dfc24c6ec7292996
    Closes-Bug: 1852808

Changed in python-swiftclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-swiftclient (master)

Reviewed: https://review.opendev.org/694635
Committed: https://git.openstack.org/cgit/openstack/python-swiftclient/commit/?id=e83cd32e2af26ecb9ac9520ac2958f186ba1888c
Submitter: Zuul
Branch: master

commit e83cd32e2af26ecb9ac9520ac2958f186ba1888c
Author: Tim Burke <email address hidden>
Date: Fri Nov 15 22:08:51 2019 +0000

    Add test for bulk-delete-attempt-counter fix

    Change-Id: Ifdeefeb4a5a3fc6895bd6cda695684de02f8c602
    Related-Change: If4af9141fe4f3436a4e9e0e2dfc24c6ec7292996
    Related-Bug: #1852808

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-swiftclient 3.9.0

This issue was fixed in the openstack/python-swiftclient 3.9.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.