swiftclient does not create a session before using keystoneclient

Bug #1738243 reported by Gage Hugo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-swiftclient
New
Undecided
Unassigned

Bug Description

keystoneclient.session has been long deprecated and is currently up for removal[0]. Using keystoneclient without providing a valid keystoneauth session has also been long deprecated and is currently slated for removal. swiftclient currently does not provide an instance of keystoneauth.session when calling keystoneclient[1][2]. As a result, it falls back onto creating a default keystoneclient.session object from the passed in values.

The fix would be to import keystoneauth1 and create a keystoneauth.session object, and pass it to keystoneclient.

[0] https://review.openstack.org/#/c/503207/
[1] https://github.com/openstack/python-swiftclient/blob/master/swiftclient/client.py#L572
[2] http://logs.openstack.org/00/527800/1/check/legacy-tempest-dsvm-neutron-src/9ddf21e/logs/screen-g-api.txt.gz#_Dec_13_23_10_17_236550

Dec 13 23:10:17.236550 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi [None req-4bd624a4-da80-4366-a46b-908201245af2 tempest-ListImageFiltersTestJSON-670415215 tempest-ListImageFiltersTestJSON-670415215] Caught error: session has been removed: Exception: session has been removed
Dec 13 23:10:17.236774 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi Traceback (most recent call last):
Dec 13 23:10:17.236981 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi File "/opt/stack/new/glance/glance/common/wsgi.py", line 1222, in __call__
Dec 13 23:10:17.237200 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi request, **action_args)
Dec 13 23:10:17.237413 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi File "/opt/stack/new/glance/glance/common/wsgi.py", line 1261, in dispatch
Dec 13 23:10:17.237627 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi return method(*args, **kwargs)
Dec 13 23:10:17.237832 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi File "/opt/stack/new/glance/glance/common/utils.py", line 363, in wrapped
Dec 13 23:10:17.238046 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi return func(self, req, *args, **kwargs)
Dec 13 23:10:17.238261 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi File "/opt/stack/new/glance/glance/api/v2/images.py", line 278, in delete
Dec 13 23:10:17.238467 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi image.delete()
Dec 13 23:10:17.238675 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi File "/opt/stack/new/glance/glance/domain/proxy.py", line 186, in delete
Dec 13 23:10:17.238877 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi self.base.delete()
Dec 13 23:10:17.239093 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi File "/opt/stack/new/glance/glance/domain/proxy.py", line 186, in delete
Dec 13 23:10:17.239299 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi self.base.delete()
Dec 13 23:10:17.246544 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi File "/opt/stack/new/glance/glance/api/policy.py", line 172, in delete
Dec 13 23:10:17.246785 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi return self.image.delete()
Dec 13 23:10:17.246999 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi File "/opt/stack/new/glance/glance/domain/proxy.py", line 186, in delete
Dec 13 23:10:17.247217 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi self.base.delete()
Dec 13 23:10:17.247425 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi File "/opt/stack/new/glance/glance/location.py", line 406, in delete
Dec 13 23:10:17.247629 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi location)
Dec 13 23:10:17.247834 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi File "/opt/stack/new/glance/glance/common/store_utils.py", line 114, in delete_image_location_from_backend
Dec 13 23:10:17.248037 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi safe_delete_from_backend(context, image_id, location)
Dec 13 23:10:17.248242 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi File "/opt/stack/new/glance/glance/common/store_utils.py", line 48, in safe_delete_from_backend
Dec 13 23:10:17.248457 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi ret = store_api.delete_from_backend(location['url'], context=context)
Dec 13 23:10:17.249656 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi File "/usr/local/lib/python2.7/dist-packages/glance_store/backend.py", line 373, in delete_from_backend
Dec 13 23:10:17.249874 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi return store.delete(loc, context=context)
Dec 13 23:10:17.250082 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi File "/usr/local/lib/python2.7/dist-packages/glance_store/capabilities.py", line 225, in op_checker
Dec 13 23:10:17.250296 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi return store_op_fun(store, *args, **kwargs)
Dec 13 23:10:17.250503 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi File "/usr/local/lib/python2.7/dist-packages/glance_store/_drivers/swift/store.py", line 1002, in delete
Dec 13 23:10:17.250710 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi location.container, location.obj)
Dec 13 23:10:17.250916 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi File "/usr/local/lib/python2.7/dist-packages/swiftclient/client.py", line 1777, in head_object
Dec 13 23:10:17.251133 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi return self._retry(None, head_object, container, obj, headers=headers)
Dec 13 23:10:17.257546 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi File "/usr/local/lib/python2.7/dist-packages/swiftclient/client.py", line 1666, in _retry
Dec 13 23:10:17.257724 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi self.url, self.token = self.get_auth()
Dec 13 23:10:17.257864 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi File "/usr/local/lib/python2.7/dist-packages/swiftclient/client.py", line 1618, in get_auth
Dec 13 23:10:17.257999 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi timeout=self.timeout)
Dec 13 23:10:17.258127 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi File "/usr/local/lib/python2.7/dist-packages/swiftclient/client.py", line 672, in get_auth
Dec 13 23:10:17.258261 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi auth_version=auth_version)
Dec 13 23:10:17.258441 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi File "/usr/local/lib/python2.7/dist-packages/swiftclient/client.py", line 576, in get_auth_keystone
Dec 13 23:10:17.258639 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi auth_url=auth_url, insecure=insecure, timeout=timeout)
Dec 13 23:10:17.259727 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi File "/opt/stack/new/python-keystoneclient/keystoneclient/v3/client.py", line 206, in __init__
Dec 13 23:10:17.259977 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi super(Client, self).__init__(**kwargs)
Dec 13 23:10:17.260206 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi File "/usr/local/lib/python2.7/dist-packages/debtcollector/renames.py", line 43, in decorator
Dec 13 23:10:17.260401 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi return wrapped(*args, **kwargs)
Dec 13 23:10:17.260650 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi File "/usr/local/lib/python2.7/dist-packages/debtcollector/renames.py", line 43, in decorator
Dec 13 23:10:17.260838 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi return wrapped(*args, **kwargs)
Dec 13 23:10:17.261024 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi File "/opt/stack/new/python-keystoneclient/keystoneclient/httpclient.py", line 369, in __init__
Dec 13 23:10:17.261225 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi session = client_session.Session._construct(kwargs)
Dec 13 23:10:17.261447 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi File "/opt/stack/new/python-keystoneclient/keystoneclient/session.py", line 603, in _construct
Dec 13 23:10:17.261636 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi return cls._make(**params)
Dec 13 23:10:17.261853 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi File "/opt/stack/new/python-keystoneclient/keystoneclient/session.py", line 628, in _make
Dec 13 23:10:17.271531 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi return cls(verify=verify, cert=cert, **kwargs)
Dec 13 23:10:17.271758 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi File "/opt/stack/new/python-keystoneclient/keystoneclient/session.py", line 139, in __init__
Dec 13 23:10:17.271936 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi raise Exception('session has been removed')
Dec 13 23:10:17.273594 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi Exception: session has been removed
Dec 13 23:10:17.273864 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: ERROR glance.common.wsgi
Dec 13 23:10:17.274308 ubuntu-xenial-rax-ord-0001429650 <email address hidden>[17531]: [pid: 17533|app: 0|req: 93/185] 127.0.0.1 () {42 vars in 1030 bytes} [Wed Dec 13 23:10:17 2017] DELETE /v2/images/f63d5977-cf6d-45cb-ac7c-5602de407d8b => generated 228 bytes in 88 msecs (HTTP/1.1 500) 4 headers in 184 bytes (1 switches on core 0)

Gage Hugo (gagehugo)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-swiftclient (master)

Change abandoned by Gage Hugo (<email address hidden>) on branch: master
Review: https://review.openstack.org/560138

Gage Hugo (gagehugo)
description: updated
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.