enabled in ClusterPolicyUpdate should be changed from string to bool

Bug #1639730 reported by miaohb
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-senlinclient
Fix Committed
Medium
miaohb

Bug Description

@@ -146,7 +147,8 @@ class ClusterPolicyUpdate(command.Command):
         self.log.debug("take_action(%s)", parsed_args)
         senlin_client = self.app.client_manager.clustering
         kwargs = {
- 'enabled': parsed_args.enabled,
+ 'enabled': strutils.bool_from_string(parsed_args.enabled,
+ strict=True),
         }

miaohb (miao-hongbao)
Changed in python-senlinclient:
status: New → In Progress
assignee: nobody → miaohb (miao-hongbao)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-senlinclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/394314

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-senlinclient (master)

Reviewed: https://review.openstack.org/394314
Committed: https://git.openstack.org/cgit/openstack/python-senlinclient/commit/?id=c003668e915c3bc136ac7699a81c06c822b63740
Submitter: Jenkins
Branch: master

commit c003668e915c3bc136ac7699a81c06c822b63740
Author: miaohb <email address hidden>
Date: Mon Nov 7 16:41:53 2016 +0800

    Revise "enabled" related code in ClusterPolicyUpdate

    Change the parsed_args "enabled" from string to bool,
    modify the related unit test

    Change-Id: I6a45693a032c59f1422421a6301ef4b66c101460
    Closed-Bug: 1639730

Qiming Teng (tengqim)
Changed in python-senlinclient:
importance: Undecided → Medium
milestone: none → ocata-2
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.