0.12.0 is using sphinx-arparse but it's not in global requirements

Bug #1551292 reported by Corey Bryant
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Python client library for Sahara
Fix Released
High
Vitalii Gridnev

Bug Description

python-saharaclient 0.12.0 is using sphinx-arparse but it's not in OpenStack's global requirements.

affects: python-swiftclient → python-saharaclient
description: updated
Revision history for this message
Vitalii Gridnev (vgridnev) wrote :

How we are using that? Seems that the only use is the doc generation, but for me it seems to be ok because we are generating docs using gate jobs

Changed in python-saharaclient:
status: New → Incomplete
Revision history for this message
Corey Bryant (corey.bryant) wrote :

Hi Vitaly,

It's used in: doc/ext/cli.py:

  from sphinxarg import ext

I hit this in ubuntu packaging when attempting to generate docs for the package. Note that distros generate documentation as well.

Thanks,
Corey

Changed in python-saharaclient:
importance: Undecided → High
assignee: nobody → Vitaly Gridnev (vgridnev)
status: Incomplete → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-saharaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/326582

Changed in python-saharaclient:
status: Confirmed → In Progress
Revision history for this message
Vitalii Gridnev (vgridnev) wrote :

Could you please validate that change is ok for you?

Revision history for this message
Luigi Toscano (ltoscano) wrote :

Corey, how does other project solve the issue? Having everyone copying the same code is not probably the proper solution...

Revision history for this message
Corey Bryant (corey.bryant) wrote :

I've not done a complete search but I don't know that any other projects use python-sphinx-argparse. It's not in global-requirements, so I'd guess no other projects use it.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-saharaclient (master)

Reviewed: https://review.openstack.org/326582
Committed: https://git.openstack.org/cgit/openstack/python-saharaclient/commit/?id=fb5557abb464b554bd16d13fa151085e27f23b13
Submitter: Jenkins
Branch: master

commit fb5557abb464b554bd16d13fa151085e27f23b13
Author: Vitaly Gridnev <email address hidden>
Date: Tue Jun 7 18:31:08 2016 +0300

    avoid additional requirement for building docs

    DocImpact

    Change-Id: I2d4dda2ee6fdfcf82702f4400a2513e7aa83957d
    closes-bug: 1551292

Changed in python-saharaclient:
status: In Progress → Fix Released
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/python-saharaclient 0.16.0

This issue was fixed in the openstack/python-saharaclient 0.16.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.