openstack rsd storage show results in error related to remote_targets

[Aneesh Pachilangottil]

I am using the latest rsd-lib and rsd-client from GitHub. When running rsd storage show command, it is resulting in an error.

stack@openstack:~/devstack$ openstack rsd storage show /redfish/v1/StorageServices/1-sv-1
Passing username and password to Connector is deprecated. Authentication is passed through set_auth now, support for these arguments will be removed in the future
'StorageService' object has no attribute 'remote_targets'

The /redfish/v1/StorageServices/1-sv-1 is an NVMeOF target which has volumes present in it.

When querying pod-manager using curl, it is showing the storage service properly.

stack@openstack:/usr/local/lib/python2.7/dist-packages/rsdclient/v1$ sudo curl -k -u admin:admin -H "Content-Type:application/json" -X GET https://10.206.111.3:8443/redfish/v1/StorageServices/1-sv-1
{
  "@odata.context" : "/redfish/v1/$metadata#StorageService.StorageService",
  "@odata.id" : "/redfish/v1/StorageServices/1-sv-1",
  "@odata.type" : "#StorageService.v1_0_0.StorageService",
  "Id" : "1-sv-1",
  "Name" : "Storage Service",
  "Description" : "Storage Service description",
  "Status" : {
    "State" : "Absent",
    "Health" : null,
    "HealthRollup" : null
  },
  "Drives" : {
    "@odata.id" : "/redfish/v1/StorageServices/1-sv-1/Drives"
  },
  "StoragePools" : {
    "@odata.id" : "/redfish/v1/StorageServices/1-sv-1/StoragePools"
  },
  "Volumes" : {
    "@odata.id" : "/redfish/v1/StorageServices/1-sv-1/Volumes"
  },
  "Endpoints" : {
    "@odata.id" : "/redfish/v1/Fabrics/1-ff-1/Endpoints"
  },
  "Links" : {
    "HostingSystem" : {
      "@odata.id" : "/redfish/v1/Systems/1-s-1"
    },
    "Oem" : {
      "Intel_RackScale" : {
        "ManagedBy" : [ {
          "@odata.id" : "/redfish/v1/Managers/1-m-1"
        } ]
      }
    }
  },
  "Oem" : { }

Looks like rsd-lib is trying to look for remote_targets resource in PODM/PSME API. But remote_targets is removed since RSD v2.2. The PSME/PODM I have uses the latest RSD version v2.3.

Please let me know if you need more information.

[Aneesh Pachilangottil (aneeeshp3)]

In rsdclient/v1/storage_service.py, the show() function is looking for remote_targets, physical_drives, and logical_drives. But these resources are not part of latest RSD spec. Instead, they should be volumes, drives, and storage_pools I guess.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/599873

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/599873
Committed: https://git.openstack.org/cgit/openstack/python-rsdclient/commit/?id=4ada7530a5c1feee91a06772790c1f6b31253df9
Submitter: Zuul
Branch: master

commit 4ada7530a5c1feee91a06772790c1f6b31253df9
Author: Lin Yang <email address hidden>
Date: Tue Sep 4 17:38:46 2018 -0700

    Update storage service for RSD 2.3

    Removed obsolete remote_targets, physical_drives, and logical_drives
    resources in storage service, but added volumes, drives, endpoints
    and storage_pools according to RSD 2.3 spec.

    Change-Id: Ie43302af5eba1699a132c8a50b8ff26150620a78
    Closes-Bug: #1789683