python-redfish has 0% unittest coverage

[Lucas Alvares Gomes]

The library is not unit-tested at all, we should improve it.

Unittest run LOG: http://paste.openstack.org/show/598397/

[Uggla (rene-ribaud)]

Yes we identified that point in our road map on the <email address hidden> ml.
Here is what was said :
Hello,

We had a sync-up meeting between core team members today (and around a
table as a follow-up as we're all local :-)

Here are the next steps that we would like to work on:

- Continue to push patches from devel into openstack/master to publish 0.4
  (uggla)
- Perform tests on HPE ProLiant Gen9 server (FW 2.50) + Moonshot cartridges
  on this base to detect potential regressions (uggla)
- Once 0.4 done, work on test infra: Mockup (docker + hosted) + virtualbmc
  (uggla, bruno)
- Enhancement Request for virtualbmc to add redfish support, then work on
  patches for it (bruno)
- Add functional tests for non-regression analysis (all)
- Add build tests (local and packaging with pb). External service ? (bruno)
- Transfer open bug reports from github to launchpad (bruno)
- Kill our former python-redfish repo to re-clone from openstack (bruno, uggla)
- get contribs from jérôme's colleague

Then we also discussed of cousins projects:
Alexandria:
- fix pep8 tests on alexandria to be able to propose reviews (tbd)
- get code from jérôme's colleague (bruno)

Ironic driver:
- Ironic standalone test platform to be setup again (bruno)
- Discuss how to reuse potential contributions from github.com/hafe/ironic-hds (bruno)
- work on functional tests (virtualbmc mandatory) (tbd)

Bruno
--
HPE EMEA EG FLOSS Technology Strategist http://www.hpe.com/engage/opensource
Open Source Profession, WW Linux Community Lead http://github.com/bcornec
FLOSS projects: http://mondorescue.org http://project-builder.org
Musique ancienne? http://www.musique-ancienne.org http://www.medieval.org

[deray (debayan-ray)]

I am closely following the recent developments in openstack/python-redfish. If you wish, I can start working on this item:

    - Once 0.4 done, work on test infra: Mockup (docker + hosted) + virtualbmc
      (uggla, bruno)

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/436793

[Bruno Cornec (bruno-cornec)]

We are adding tests with the DMTF mockup for version 0.5 using Docker containers Cf: https://review.openstack.org/#/c/430161/

As on gerrit the Docker socket is not present, these tests are not run. It's a first approach with some basic tests that everything is just running.

We plan on hosting the mockup online to enrich tests later on and provide some unit tests. We'd be happy that you (deray) contribute to the test infrastructure as soon as it's ready to be used.

virtualbmc would need to be extended with basic power on/off/reset features first, and ultimately we should merge the DMTF mockup with it fully (longer term goal).

[Lucas Alvares Gomes (lucasagomes)]

@Bruno this bug is about unit-tests I think you are talking about functional tests. For unit-tests we should not depend on any mockup server to be running in order to execute it, the APIs should be mocked so they are isolated from the service layer.

re: Adding RedFish support for VirtualBMC. I'm not sure it would be a good idea since VirtualBMC might die off in a year or two. At the moment QEMU is working on implementing IPMI [0] and once the distro we use in gate contains the right version of QEMU the project won't be needed anymore.

[0] https://lists.nongnu.org/archive/html/qemu-devel/2015-04/msg00483.html

[OpenStack Infra (hudson-openstack)]

Change abandoned by ribaudr (<email address hidden>) on branch: master
Review: https://review.openstack.org/436793
Reason: Abandon as requested.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Bruno Cornec (<email address hidden>) on branch: master
Review: https://review.opendev.org/443431
Reason: Sorry too old now to be merged. Please resubmit if still appropriate.