Unit tests should not perform logging,but some tests still use

Bug #1600109 reported by jingtao liang on 2016-07-08
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Undecided
jingtao liang
Glance
Undecided
weiweigu
Glance Client
Undecided
YaoZheng_ZTE
Magnum
Undecided
hongzhezheng
OpenStack Compute (nova)
Undecided
Bin Zhou
OpenStack DBaaS (Trove)
Undecided
Unassigned
OpenStack Identity (keystone)
Undecided
Ji.Wei
OpenStack Object Storage (swift)
Undecided
Unassigned
python-cinderclient
Undecided
YaoZheng_ZTE
python-keystoneclient
Undecided
Ji.Wei
python-novaclient
Undecided
YaoZheng_ZTE
python-rackclient
Undecided
Ji.Wei
python-swiftclient
Undecided
hongzhezheng
rack
Undecided
Ji.Wei

Bug Description

We shuld remove the logging

Changed in cinder:
assignee: nobody → jingtao liang (liang-jingtao)
Changed in glance:
assignee: nobody → weiweigu (gu-weiwei)
yuyafei (yu-yafei) on 2016-07-08
Changed in os-brick:
assignee: nobody → yuyafei (yu-yafei)
Changed in rally:
assignee: nobody → yuyafei (yu-yafei)
Changed in glance-store:
assignee: nobody → yuyafei (yu-yafei)
Changed in python-glanceclient:
assignee: nobody → YaoZheng_ZTE (zheng-yao1)
Changed in python-cinderclient:
assignee: nobody → YaoZheng_ZTE (zheng-yao1)
Changed in python-novaclient:
assignee: nobody → YaoZheng_ZTE (zheng-yao1)
yuyafei (yu-yafei) on 2016-07-08
Changed in neutron:
assignee: nobody → yuyafei (yu-yafei)
Changed in tempest:
assignee: nobody → yuyafei (yu-yafei)
Ji.Wei (jiwei) on 2016-07-08
Changed in swift:
assignee: nobody → Ji.Wei (jiwei)
yuyafei (yu-yafei) on 2016-07-08
Changed in python-heatclient:
assignee: nobody → yuyafei (yu-yafei)
Ji.Wei (jiwei) on 2016-07-08
Changed in keystone:
assignee: nobody → Ji.Wei (jiwei)
Bin Zhou (binzhou) on 2016-07-08
Changed in nova:
assignee: nobody → Bin Zhou (binzhou)
Changed in ceilometer:
assignee: nobody → Bin Zhou (binzhou)
Ji.Wei (jiwei) on 2016-07-08
Changed in nova:
assignee: Bin Zhou (binzhou) → Ji.Wei (jiwei)
assignee: Ji.Wei (jiwei) → nobody
Bin Zhou (binzhou) on 2016-07-08
Changed in rack:
assignee: nobody → Bin Zhou (binzhou)
Ji.Wei (jiwei) on 2016-07-08
Changed in rack:
assignee: Bin Zhou (binzhou) → Ji.Wei (jiwei)
Bin Zhou (binzhou) on 2016-07-08
Changed in nova:
assignee: nobody → Bin Zhou (binzhou)
Ji.Wei (jiwei) on 2016-07-08
Changed in python-rackclient:
assignee: nobody → Ji.Wei (jiwei)
Changed in magnum:
assignee: nobody → hongzhezheng (zheng-hongzhe32)
Changed in python-swiftclient:
assignee: nobody → hongzhezheng (zheng-hongzhe32)
Changed in python-keystoneclient:
assignee: nobody → hongzhezheng (zheng-hongzhe32)
Ji.Wei (jiwei) on 2016-07-08
Changed in python-keystoneclient:
assignee: hongzhezheng (zheng-hongzhe32) → Ji.Wei (jiwei)
haobing1 (haobing1) on 2016-07-08
Changed in trove:
assignee: nobody → haobing1 (haobing1)
Changed in python-neutronclient:
assignee: nobody → YaoZheng_ZTE (zheng-yao1)
Amrith Kumar (amrith) wrote :

Without more details about this, it is hard to tell what this bug is about. How can code not perform logging just because it is in unit tests? Heck, some tests actually verify that messages are being logged.

Changed in trove:
status: New → Opinion
Brant Knudson (blk-u) wrote :

What problem is this causing?

Changed in python-keystoneclient:
status: New → Incomplete
David Stanek (dstanek) on 2016-07-08
Changed in keystone:
status: New → Incomplete
Dolph Mathews (dolph) wrote :

> Unit tests should not perform logging

Why not? Debugging is useful.

Changed in ceilometer:
status: New → Incomplete
Amrith Kumar (amrith) wrote :

marking incomplete for Trove per IRC chat with keystone folks.

Changed in trove:
status: Opinion → Incomplete
Dolph Mathews (dolph) on 2016-07-08
Changed in cinder:
status: New → Incomplete
Changed in glance:
status: New → Incomplete
Changed in magnum:
status: New → Incomplete
Changed in nova:
status: New → Incomplete
Changed in swift:
status: New → Incomplete
Dolph Mathews (dolph) on 2016-07-08
Changed in rally:
status: New → Incomplete
Changed in glance-store:
status: New → Incomplete
Changed in neutron:
status: New → Incomplete
Changed in os-brick:
status: New → Incomplete
Changed in python-cinderclient:
status: New → Incomplete
Dolph Mathews (dolph) on 2016-07-08
Changed in python-glanceclient:
status: New → Incomplete
Changed in python-heatclient:
status: New → Incomplete
Changed in python-neutronclient:
status: New → Incomplete
Changed in python-novaclient:
status: New → Incomplete
Changed in python-rackclient:
status: New → Incomplete
Changed in python-swiftclient:
status: New → Incomplete
Changed in rack:
status: New → Incomplete
Changed in tempest:
status: New → Incomplete
Dolph Mathews (dolph) wrote :

Without any presenting any reasoning or justification, this "bug" seems opinionated, wasteful, and counter-productive.

Ian Cordasco (icordasc) wrote :

I have to agree with Dolph. I'm inclined to mark it as "won't fix" for glance.

jingtao liang (liang-jingtao) wrote :

@Dolph Mathews (dolph) Ian Cordasco (icordasc)

Hello, i'm sorry to give the reason here so later.But in the cinder HACKING.rst,you can see the Cinder Specific Commandments [C309].You will see :Unit tests should not perform logging.

David Stanek (dstanek) wrote :

Marking as WONTFIX for now because I don't think this is a keystone issue at all. If you find a place in keystone where there is a problem feel free to reopen.

Changed in keystone:
status: Incomplete → Won't Fix
Changed in python-keystoneclient:
status: Incomplete → Won't Fix
yuyafei (yu-yafei) on 2016-08-01
Changed in os-brick:
assignee: yuyafei (yu-yafei) → nobody
no longer affects: os-brick
no longer affects: python-heatclient
no longer affects: neutron
no longer affects: rally
no longer affects: glance-store
no longer affects: tempest

Nova has no rules in place which forbids that, so it's not a bug. I also don't see a reason to put effort into this.

Changed in nova:
status: Incomplete → Invalid
Changed in python-novaclient:
status: Incomplete → Invalid
Amrith Kumar (amrith) wrote :

This is not a bug (in Trove).

Changed in trove:
assignee: haobing1 (haobing1) → nobody
status: Incomplete → Invalid
Changed in cinder:
status: Incomplete → Invalid
Changed in python-cinderclient:
status: Incomplete → Invalid
gordon chung (chungg) on 2016-11-02
no longer affects: ceilometer
Akihiro Motoki (amotoki) on 2017-04-18
no longer affects: python-neutronclient
Tim Burke (1-tim-z) on 2017-09-27
Changed in swift:
assignee: Ji.Wei (jiwei) → nobody
status: Incomplete → Invalid
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers