Resource props of type=resource cause issue with basepath
Bug #1440257 reported by
Terry Howe
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenStack SDK |
In Progress
|
Critical
|
Brian Curtin | ||
Bug Description
If the base_path contains a key from a resource property, it is potentially not going to work if the resource.prop type=someResource. We should perhaps handle this in a generalized way. This review shows the problem:
https:/
| Changed in python-openstacksdk: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| milestone: | none → 1.0 |
Revision history for this message
| Terry Howe (thowe-g) wrote | #1 |
| tags: | added: resource |
| Changed in python-openstacksdk: | |
| assignee: | nobody → Terry Howe (thowe-g) |
| Changed in python-openstacksdk: | |
| status: | Confirmed → In Progress |
| Changed in python-openstacksdk: | |
| assignee: | Terry Howe (thowe-g) → Brian Curtin (brian.curtin) |
| importance: | Medium → Critical |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Change abandoned on python-openstacksdk (master) | #2 |
To post a comment you must log in.
I added a _get_url method for this ticket in the resource class. That should centralize where we are dealing with the problem.
What I wanted to try is using format instead of % so maybe it could take advantage of {image.id}. If that doesn't work or isn't popular, I guess derived classes might need to override _get_url.