conflict with "get" method when props are resources

[Brian Curtin]

In the process of doing an attribute access on the id of a resource.prop that is an ID and has type=resource, because of our overloaded use of the "get" function, we end up trying to make a HTTP GET instead of dictionary get.

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/brian/rackspace/openstack/python-openstacksdk/openstack/image/v2/tag.py", line 53, in create
    return self._call(session.put)
  File "/Users/brian/rackspace/openstack/python-openstacksdk/openstack/image/v2/tag.py", line 34, in _call
    {"image_id": self._get_id(self.image)}, tag)
  File "/Users/brian/rackspace/openstack/python-openstacksdk/openstack/resource.py", line 462, in _get_id
    return value.id
  File "/Users/brian/rackspace/openstack/python-openstacksdk/openstack/resource.py", line 392, in id
    return self._attrs.get(self.id_attribute, None)
  File "/Users/brian/rackspace/openstack/python-openstacksdk/openstack/resource.py", line 619, in get
    include_headers=include_headers)
  File "/Users/brian/rackspace/openstack/python-openstacksdk/openstack/resource.py", line 572, in get_data_by_id
    response = session.get(url, service=cls.service)
AttributeError: 'str' object has no attribute 'get'

We should be more defensive, either checking if it's a resource or using subscript notation instead.

[Terry Howe (thowe-g)]

I saw this one too, but it seemed like it was my own fault. The thing is it is a really confusing error until you finally look up the stack trace.

[Brian Curtin (brian.curtin)]

Yeah, this is what you had shown me once after running that server_builder, which I couldn't reproduce. I got this while toying around in the interpreter, but was dumb enough to clear my screen after it to lose what I had done. I'm still trying to reproduce it, but at least we have a traceback.

[Terry Howe (thowe-g)]

Are we done with this problem?

[Brian Curtin (brian.curtin)]

I think we are, or at least I haven't seen it. Can reopen if we come across it again.