resource.header with no alias causes AttributeError

[Brian Curtin]

When a resource.header has no alias and its original name is not found, we raise a KeyError on the original name, and then we go try to look up the alias name. Since resource.header is looking into requests' CaseInsensitiveDict, alias=None and it tries to call lower() on None, causing an AttributeError. We currently only expect KeyError on that alias lookup, so this blows up.

We will always have a name, but not always an alias. If we catch AttributeError as well, we'll be safe.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/161438

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/161438
Committed: https://git.openstack.org/cgit/stackforge/python-openstacksdk/commit/?id=ea01e73948b20a49e452c11c3f4a628631df1dd9
Submitter: Jenkins
Branch: master

commit ea01e73948b20a49e452c11c3f4a628631df1dd9
Author: Brian Curtin <email address hidden>
Date: Wed Mar 4 15:57:49 2015 -0600

    Catch AttributeError in header with no alias

    Now that resource.header is a thing and it's populated with the headers
    from a requests.Response, which is a
    requests.structures.CaseInsensitiveDict, we have to take an extra step
    to make sure we don't try and convert a None-alias to lower case.

    Change-Id: I47704191d1822d468389986c5ab203781af59074
    Closes-Bug: 1428342