default_security_group_rule custom sg default true with no way to override

Bug #2054629 reported by James Black
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-openstackclient
Fix Released
Undecided
James Black

Bug Description

https://github.com/openstack/python-openstackclient/blob/master/openstackclient/network/v2/default_security_group_rule.py#L145C21-L145C25

```
        parser.add_argument(
            '--for-custom-sg',
            action='store_true',
            default=True,
            help=_(
                "Set this default security group rule to be used in all "
                "custom security groups created manually by users"
            ),
        )
        return parser
```

default should be False

Not sure why it would be set to True, there is no way to override this to not apply.

Tested by setting to false and now works as expected.

Revision history for this message
James Black (hamburgler) wrote :
Changed in python-openstackclient:
status: New → In Progress
James Black (hamburgler)
Changed in python-openstackclient:
assignee: nobody → James Black (jblackosa)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-openstackclient (master)

Reviewed: https://review.opendev.org/c/openstack/python-openstackclient/+/909815
Committed: https://opendev.org/openstack/python-openstackclient/commit/93b73e9b2968fe2a8a488bc68edc38dd5f07354b
Submitter: "Zuul (22348)"
Branch: master

commit 93b73e9b2968fe2a8a488bc68edc38dd5f07354b
Author: James Black <email address hidden>
Date: Wed Feb 21 19:50:28 2024 -0800

     Bug Fix, Default SG Rule Custom SG

    Currently the Default setting for CustomSG Rule
    is set to True, this means all new SGs inherit
    these rules, with no way for user to override
    this behavior.

    Closes Bug: #2054629

    Change-Id: Icef7c91654dbced76a5492437e723c4e2a0f3102

Changed in python-openstackclient:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.