Wrong error message when cannot create server

[Bence Romsics]

I found a small osc bug when creating a server which fails:

$ openstack flavor create toobig --public --vcpus 16 --ram 51200 --disk 1
+----------------------------+--------------------------------------+
| Field | Value |
+----------------------------+--------------------------------------+
| OS-FLV-DISABLED:disabled | False |
| OS-FLV-EXT-DATA:ephemeral | 0 |
| description | None |
| disk | 1 |
| id | 3e7bf18b-fa73-4751-b4dc-d3ad20fc9b4e |
| name | toobig |
| os-flavor-access:is_public | True |
| properties | |
| ram | 51200 |
| rxtx_factor | 1.0 |
| swap | 0 |
| vcpus | 16 |
+----------------------------+--------------------------------------+
$ openstack server create --flavor toobig --image cirros-0.6.2-x86_64-disk --nic net-id=private vm0 --wait
Error unshelving server: vm0

Here, the error message should say "creating", not "unshelving".

Above the flavor is intentionally too big for my environment, so the server create goes to status=ERROR with fault=NoValidHost. The following recent refactoring change seems to have introduced the wrong error message, where likely it was an unintended copy-paste error:

https://review.opendev.org/c/openstack/python-openstackclient/+/901020/1/openstackclient/compute/v2/server.py#1991

relevant versions:
python-openstackclient f3207bdf

Submitting a fix soon.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/python-openstackclient/+/905216

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-openstackclient/+/905216
Committed: https://opendev.org/openstack/python-openstackclient/commit/cc2a0bab2499a6ac6554cd681c2ed4f60aa7a3c2
Submitter: "Zuul (22348)"
Branch: master

commit cc2a0bab2499a6ac6554cd681c2ed4f60aa7a3c2
Author: Bence Romsics <email address hidden>
Date: Wed Jan 10 14:11:52 2024 +0100

    Correct error message for "create server --wait"

    Error message should say "Error creating server" and not "unshelving".

    Change-Id: I49dc6160f47a13d38128b3da1ba16437bd089c86
    Closes-Bug: #2048896

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-openstackclient 6.5.0 release.