QoS - “port” parameter is required in CLI in order to set/unset QoS policy to floating IP
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
python-openstackclient |
Won't Fix
|
Low
|
Lajos Katona |
Bug Description
### User Workflow (Documentation) ###
According documentation https:/
1) Set QoS to Floating IP:
openstack floating ip set --qos-policy bw-limiter d0ed7491-
2) Remove Floating IP (option 1):
openstack floating ip set --no-qos-policy d0ed7491-
3) Remove Floating IP (option 2)
openstack floating ip unset --qos-policy d0ed7491-
### Testing Result ###
1) Set QoS to floating IP
# Scenario #
openstack floating ip set --no-qos-policy b2895ad6-
# Actual Result #
Fails with:
(openstack) floating ip set --no-qos-policy b2895ad6-
usage: floating ip set [-h] --port <port> [--fixed-ip-address <ip-address>]
floating ip set: error: argument --port is required
There is no match between “set command” in documentation and implemented code.
Once “port” parameter is provided, QoS is set as expected.
“Set command” provided in documentation absolutely OK (“floating-ip” should be a single mandatory parameter), so the problem here is our implementation.
I think that we have to check the “Port” value in our code, basing on provided by user “Floating-IP” and then to use it. So this will be kind of workaround and will be transparent to user.
2) Unset QoS from Floating IP with “set –no-qos-policy” option
# Scenario #
openstack floating ip set --no-qos-policy b2895ad6-
# Actual Result #
Fails with:
(openstack) floating ip set --no-qos-policy b2895ad6-
usage: floating ip set [-h] --port <port> [--fixed-ip-address <ip-address>]
floating ip set: error: argument --port is required
Similar to previous “Set QoS”, again no match between the command provided in documentation and our current implementation.
And again, documentation command is OK, the problem is in our implementation. My suggestion is the same workaround, means getting “Port” from code, basing on provided “Floating IP”
3) Unset QoS from Floating IP with “unset” option
# Scenario #
openstack floating ip unset --qos-policy b2895ad6-
# Actual Result #
Works as expected and no “port” value is needed, maybe this info will help the developers to understand why #1 and #2 scenarios behaves diferently.
tags: | added: qos |
Changed in neutron: | |
importance: | Undecided → Low |
status: | New → Confirmed |
Changed in python-openstackclient: | |
status: | Confirmed → Won't Fix |
I tried to reproduce on fresh master, without success, see my commands please: 07b0-48e6- 9d8e-5e3a0f88a4 e4 07b0-48e6- 9d8e-5e3a0f88a4 e4 ------- ------- -+----- ------- ------- ------- ------- -----+ ------- ------- -+----- ------- ------- ------- ------- -----+ 26T15:11: 44Z | 3d99-446c- af4a-4cb7daaba3 6d | 07b0-48e6- 9d8e-5e3a0f88a4 e4 | 29106e6726981f1 8b | 81ac-45d9- 9666-c5dd43cac9 42 | 26T15:22: 03Z | ------- ------- -+----- ------- ------- ------- ------- -----+
openstack network qos policy create p1
openstack network qos rule create p1 --type bandwidth-limit --max-kbps 1000
openstack floating ip create public
openstack floating ip set --qos-policy p1 bd8de6f8-
openstack floating ip show bd8de6f8-
+------
| Field | Value |
+------
| created_at | 2018-07-
| description | |
| dns_domain | None |
| dns_name | None |
| fixed_ip_address | None |
| floating_ip_address | 172.24.4.6 |
| floating_network_id | e0652260-
| id | bd8de6f8-
| name | 172.24.4.6 |
| port_details | None |
| port_id | None |
| project_id | 91c8b75eac0d45d
| qos_policy_id | 82d52bf7-
| revision_number | 10 |
| router_id | None |
| status | DOWN |
| subnet_id | None |
| tags | [] |
| updated_at | 2018-07-
+------
openstack floating ip set --no-qos-policy bd8de6f8- 07b0-48e6- 9d8e-5e3a0f88a4 e4 07b0-48e6- 9d8e-5e3a0f88a4 e4 ------- ------- -+----- ------- ------- ------- ------- -----+ ------- ------- -+----- ------- ------- ------- ------- -----+ 26T15:11: 44Z | 3d99-446c- af4a-4cb7daaba3 6d | 07b0-48e6- 9d8e-5e3a0f88a4 e4 | 29106e6726981f1 8b |
openstack floating ip show bd8de6f8-
+------
| Field | Value |
+------
| created_at | 2018-07-
| description | |
| dns_domain | None |
| dns_name | None |
| fixed_ip_address | None |
| floating_ip_address | 172.24.4.6 |
| floating_network_id | e0652260-
| id | bd8de6f8-
| name | 172.24.4.6 |
| port_details | None |
| port_id | None |
| project_id | 91c8b75eac0d45d
| qos_policy_id | None |
| revision_number | 12 |
| router_id | None |
| status | DOWN |
| subnet_id | None ...