pycodestyle >= 2.4.0 errors on previously ignored issues

[Sean McGinnis]

W503 and E402 are now enforced by default. Current master run of tox -e pep8 results in:

./openstackclient/__init__.py:16:1: E402 module level import not at top of file
import pbr.version
^
./openstackclient/identity/v3/role.py:130:17: W503 line break before binary operator
                and not parsed_args.group and not parsed_args.project):
                ^
./openstackclient/identity/v3/role.py:403:17: W503 line break before binary operator
                and not parsed_args.group and not parsed_args.project):
                ^
./openstackclient/network/v2/router.py:90:13: W503 line break before binary operator
            and parsed_args.availability_zone_hints is not None):
            ^
./openstackclient/image/v1/image.py:29:1: E402 module level import not at top of file
from glanceclient.common import utils as gc_utils
^
./openstackclient/image/v1/image.py:30:1: E402 module level import not at top of file
from osc_lib.cli import parseractions
^
./openstackclient/image/v1/image.py:31:1: E402 module level import not at top of file
from osc_lib.command import command
^
./openstackclient/image/v1/image.py:32:1: E402 module level import not at top of file
from osc_lib import utils
^
./openstackclient/image/v1/image.py:33:1: E402 module level import not at top of file
import six
^
./openstackclient/image/v1/image.py:35:1: E402 module level import not at top of file
from openstackclient.api import utils as api_utils
^
./openstackclient/image/v1/image.py:36:1: E402 module level import not at top of file
from openstackclient.i18n import _
^
./openstackclient/common/extension.py:79:21: W503 line break before binary operator
                    and not parsed_args.volume and not parsed_args.network)
                    ^
./openstackclient/tests/functional/volume/v1/test_volume_type.py:59:37: W503 line break before binary operator
                                    + self.NAME)
                                    ^
./openstackclient/tests/functional/volume/v2/test_volume_type.py:65:37: W503 line break before binary operator
                                    + self.NAME)
                                    ^
./openstackclient/tests/functional/object/v1/test_object.py:57:37: W503 line break before binary operator
                                    + ' ' + object_file)
                                    ^
./openstackclient/tests/functional/object/v1/test_object.py:66:24: W503 line break before binary operator
                       + ' ' + object_file)
                       ^
./openstackclient/tests/functional/object/v1/test_object.py:72:24: W503 line break before binary operator
                       + ' ' + object_file + ' --file ' + tmp_file)
                       ^
./openstackclient/tests/functional/object/v1/test_object.py:76:37: W503 line break before binary operator
                                    + ' ' + object_file + ' --file -')
                                    ^
./openstackclient/tests/functional/object/v1/test_object.py:80:24: W503 line break before binary operator
                       + ' ' + object_file)
                       ^
./openstackclient/tests/functional/object/v1/test_object.py:84:37: W503 line break before binary operator
                                    + ' ' + object_file)
                                    ^
./openstackclient/tests/functional/object/v1/test_object.py:88:24: W503 line break before binary operator
                       + ' ' + object_file)
                       ^
./openstackclient/tests/functional/network/v2/test_network.py:390:13: W503 line break before binary operator
            + agent_id + ' ' + network_id
            ^
./openstackclient/tests/functional/network/v2/test_network.py:402:13: W503 line break before binary operator
            + agent_id + ' ' + network_id
            ^
./openstackclient/tests/functional/network/v2/test_network_agent.py:120:13: W503 line break before binary operator
            + agent_id + ' ' + network_id
            ^
./openstackclient/tests/functional/network/v2/test_network_agent.py:132:13: W503 line break before binary operator
            + agent_id + ' ' + network_id
            ^
./openstackclient/tests/functional/network/v2/test_network_flavor.py:42:13: W503 line break before binary operator
            + 'fakedescription' + ' --enable --metainfo ' + 'Extrainfo'
            ^
./openstackclient/tests/functional/network/v2/test_network_qos_rule.py:205:13: W503 line break before binary operator
            + self.QOS_POLICY_NAME))
            ^
./openstackclient/tests/functional/network/v2/test_port.py:196:13: W503 line break before binary operator
            + 'port set --mac-address 11:22:33:44:55:66 '
            ^
./openstackclient/tests/functional/network/v2/test_port.py:197:13: W503 line break before binary operator
            + self.NAME)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/560132

[Matt Riedemann (mriedem)]

https://review.openstack.org/560132 is merged, I'm not sure why this bug isn't marked closed for rocky.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-openstackclient 3.14.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-openstackclient 3.16.0 release.