"openstack server remove floating ip" broken with python-novaclient 10.0.0

Bug #1745795 reported by Matt Riedemann on 2018-01-28
24
This bug affects 7 people
Affects Status Importance Assigned to Milestone
grenade
Undecided
Matt Riedemann
python-openstackclient
Fix Committed
Undecided
Unassigned

Bug Description

Seen here:

https://review.openstack.org/#/c/538070/

python-novaclient 10.0.0 removed the deprecated Server.remove_floating_ip python API binding.

So grenade fails here:

http://logs.openstack.org/70/538070/2/check/neutron-grenade-multinode/1047508/logs/grenade.sh.txt.gz#_2018-01-28_00_07_16_094

This is the broken OSC code:

http://git.openstack.org/cgit/openstack/python-openstackclient/tree/openstackclient/compute/v2/floatingip.py#n97

We'd likely need to deprecate the OSC CLI and in the same change, change that code to use the networking API code rather than novaclient.

Fix proposed to branch: master
Review: https://review.openstack.org/538541

Changed in grenade:
assignee: nobody → Matt Riedemann (mriedem)
status: New → In Progress

Reviewed: https://review.openstack.org/538541
Committed: https://git.openstack.org/cgit/openstack-dev/grenade/commit/?id=fce6befbb50fdc774f16fa963dd51e2bb8eedd63
Submitter: Zuul
Branch: master

commit fce6befbb50fdc774f16fa963dd51e2bb8eedd63
Author: Matt Riedemann <email address hidden>
Date: Sat Jan 27 21:18:16 2018 -0500

    Stop using openstack server remove floating ip

    The openstack server remove floating ip CLI no longer works
    with python-novaclient 10.0.0 directly because novaclient
    removed it's deprecated API bindings for updating a floating
    IP to unset it's associated port.

    We need to fix python-openstackclient, deprecate that CLI and
    eventually remove it, but at the same time, we can get ahead of
    that deprecation and change to the 'floating ip unset --port' CLI.

    Change-Id: I63d69bc2b96df04777f00f32930e92564e33e8c2
    Closes-Bug: #1745795

Changed in grenade:
status: In Progress → Fix Released

Change abandoned by Matt Riedemann (<email address hidden>) on branch: master
Review: https://review.openstack.org/538539
Reason: Looks like Dean fixed this in https://review.openstack.org/#/c/550105/

Matt Riedemann (mriedem) on 2018-03-21
Changed in python-openstackclient:
status: New → Fix Committed

This issue was fixed in the openstack/python-openstackclient 3.14.2 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers