openstack subnet create fails when tags is None

Bug #1735836 reported by Carlos Konstanski on 2017-12-01
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-openstackclient
Fix Released
Undecided
Carlos Konstanski

Bug Description

In ntwork/v2/_tag.py lines 105 and 110: obj.tags can be None, in which case set(obj.tags) throws a NoneType exception.

Quickest and dirtiest fix: set(obj.tags or []) in both these lines.

More involved fix: should obj.tags ever be None? Should it default to [] instead?

Carlos Konstanski (ckonstanski) wrote :

Darn typo. network/v2/_tag.py

Carlos Konstanski (ckonstanski) wrote :

Please assign to me (ckonstanski).

Changed in python-openstackclient:
assignee: nobody → Carlos Konstanski (ckonstanski)
status: New → In Progress
Carlos Konstanski (ckonstanski) wrote :

A pastebin showing the error: https://pastebin.com/s0m24Zaa

Reviewed: https://review.openstack.org/524739
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=dab49df461d7ca68001632f11dc5bf1229271de9
Submitter: Zuul
Branch: master

commit dab49df461d7ca68001632f11dc5bf1229271de9
Author: Carlos Konstanski <email address hidden>
Date: Fri Dec 1 14:58:52 2017 -0700

    openstack subnet create fails when tags is None

    In network/v2/_tag.py lines 105 and 110: obj.tags can be None, in
    which case set(obj.tags) throws a NoneType exception.

    Change-Id: I1e965ec947844cbf84676fab27a2261fc0c0ea49
    Closes-Bug: #1735836

Changed in python-openstackclient:
status: In Progress → Fix Released

This issue was fixed in the openstack/python-openstackclient 3.13.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers