Unable to create server group with soft-anti-affinity policy using microversion 2.15

[Matt Riedemann]

The compute API microversion 2.15 adds the soft-affinity and soft-anti-affinity policies to the server groups API, however, even when requesting to create a server group via OSC using microversion 2.15 it fails because OSC hard-codes the policy choices:

https://github.com/openstack/python-openstackclient/blob/3.12.0/openstackclient/compute/v2/server_group.py#L58

http://paste.openstack.org/show/626622/

OSC should arguably either (1) check that a microversion is requested and update the choices on the fly or (2) remove the hard-coded list of choices and just let the server handle a bad request for an unsupported policy.

[Dean Troyer (dtroyer)]

OSC does most of its value checking for help purposes, and to fail a tiny bit faster. I'd be OK with just removing the value checks for the current version and doing the Right Thing in OSC4

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/521397
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=d0917cd14b94ce13fd92237490efb5722761eda4
Submitter: Zuul
Branch: master

commit d0917cd14b94ce13fd92237490efb5722761eda4
Author: Matt Riedemann <email address hidden>
Date: Sun Nov 19 18:34:24 2017 -0500

    Remove hard-coded policy choices for creating a server group

    The hard-coded choices for the server group policy make it impossible
    to create a server group with the soft-affinity or
    soft-anti-affinity policy rules which were added in compute API
    microversion 2.15. This removes the hard-coded choices so that the
    policy is restricted on the server side rather than the client side.

    Change-Id: Ib3dc39422ac1015872d56ae2fdeddf0f29613494
    Closes-Bug: #1732938

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/523858

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/523858
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=f7701cd6bc36aae5adb6ece553cbc4dc914790e3
Submitter: Zuul
Branch: stable/pike

commit f7701cd6bc36aae5adb6ece553cbc4dc914790e3
Author: Matt Riedemann <email address hidden>
Date: Sun Nov 19 18:34:24 2017 -0500

    Remove hard-coded policy choices for creating a server group

    The hard-coded choices for the server group policy make it impossible
    to create a server group with the soft-affinity or
    soft-anti-affinity policy rules which were added in compute API
    microversion 2.15. This removes the hard-coded choices so that the
    policy is restricted on the server side rather than the client side.

    Change-Id: Ib3dc39422ac1015872d56ae2fdeddf0f29613494
    Closes-Bug: #1732938
    (cherry picked from commit d0917cd14b94ce13fd92237490efb5722761eda4)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-openstackclient 3.13.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-openstackclient 3.12.1 release.