Breakage of OSC plugin prevent OSC to work
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
python-openstackclient |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Description
===========
If there is an exception on importing OSC plugin module (for various reason such as the plugin is broken), OSC will stop execution of the command.
Reproduce
=========
* Install OSC
* Install a broken plugin
* Execute any command. For example:
$ openstack network list
Traceback (most recent call last):
File "/usr/bin/
from openstackclient
File "/home/
from openstackclient
File "/home/
'openstack.
File "/home/
__import_
File "/opt/stack/
API_
KeyError: '1.11'
Expected result
===============
The command should continue to execute. OSC prints warning on the failure of importing plugin.
Actual result
=============
The command stopped executing.
Reviewed: https:/ /review. openstack. org/510308 /git.openstack. org/cgit/ openstack/ python- openstackclient /commit/ ?id=599fa782623 598208c012125dd 988a48774cfc6e
Committed: https:/
Submitter: Zuul
Branch: master
commit 599fa7826235982 08c012125dd988a 48774cfc6e
Author: Hongbin Lu <email address hidden>
Date: Sat Oct 7 14:03:14 2017 -0400
Be robust on import plugin module
On loading external plugin, OSC should be robust on importing the
plugin module so that commands from other modules can continue to
execute.
Closes-Bug: #1722008 abee31b7ef281af 2588d68ab30
Change-Id: Ibe716681c7f78f