Useless line of code in shell.py

[Huan Xiong]

This line in shell.py is useless:

  osprofiler_profiler = importutils.try_import("osprofiler.profiler")

It was introduced in commit 16f00833 where it was useful. Most code in that commit was later moved to osc-lib in commit 6a15f90d. However, the above line was left uncleaned up.

[Corey Bryant (corey.bryant)]

Hi Huan,

Thanks for reporting this bug. This is reported against the Ubuntu package only, so I'm going to also target the upstream python-openstackclient project. We'll need to get this fix upstream before backporting to the Ubuntu package.

Thanks,
Corey

[Huan Xiong (huan.xiong)]

Corey, thanks for pointing that out. It was the first bug I created on
launchpad and I didn't notice the difference. I thought I was on upstream
project page.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/501966
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=61025bf1023328893904c3cc00bea28a238be544
Submitter: Jenkins
Branch: master

commit 61025bf1023328893904c3cc00bea28a238be544
Author: Huan Xiong <email address hidden>
Date: Fri Sep 8 06:28:15 2017 +0000

    Useless line of code in shell.py

    Shell.py contains lines to import osprofiler. This is useless
    because osprofiler options support code was moved to osc-lib.

    Removed it.

    Change-Id: Ibec17700c87df908640848c3787d190ca66a7bcf
    Closes-Bug: #1707103

[James Page (james-page)]

Marking Ubuntu task as invalid; this will be included in the next set of updates for openstackclient.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-openstackclient 3.13.0 release.