[RFE] More detailed reporting of available QoS rules

Bug #1686035 reported by Slawek Kaplonski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Wishlist
Slawek Kaplonski

Bug Description

Currently Neutron has API call "qos-available-rule-types" which will return subset of qos rules supported by all loaded drivers (openvswitch, linuxbridge, etc.)
After https://bugs.launchpad.net/neutron/+bug/1586056 was closed it can be not enough sometimes.

I would suggest to add new API call to report details about supported rules. It should returns something like

+--------+---------------------+----------------------------+
| Driver | Supported rule | Supported parameters |
+--------+---------------------+----------------------------+
| ovs |bandwidth_limit_rule | direction: egress |
| | | max_kbps: ANY VALUE |
+--------+---------------------+----------------------------+
| LB |bandwidth_limit_rule | direction: egress, ingress |
| | | max_kbps: ANY VALUE |
+--------+---------------------+----------------------------+

Thanks to that API call operator will be able to discover exactly which rules and with what values can be applied to ports bound with specific driver.
As such call can leak used driver names to the users it should be available only for admins.

Changed in neutron:
assignee: nobody → Slawek Kaplonski (slaweq)
Miguel Lavalle (minsel)
Changed in neutron:
importance: Undecided → Medium
status: New → Triaged
summary: - More detailed reporting of available QoS rules
+ [RFE] More detailed reporting of available QoS rules
description: updated
description: updated
Miguel Lavalle (minsel)
Changed in neutron:
importance: Medium → Wishlist
Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

It seems like you attempt to implement API discovery, just for QoS. There was an attempt to standardize on a single approach for all openstack services: https://review.openstack.org/#/c/386555/7/guidelines/capabilities.rst though it seems abandoned. What can we make out of it? Would it make sense to look at this problem more widely than just for qos?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron-specs (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/466500

tags: added: rfe-approved
removed: rfe
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron-specs (master)

Reviewed: https://review.openstack.org/466500
Committed: https://git.openstack.org/cgit/openstack/neutron-specs/commit/?id=a5db1db2bb34c1d3bb2bc279ddc7d64a4ac9824e
Submitter: Jenkins
Branch: master

commit a5db1db2bb34c1d3bb2bc279ddc7d64a4ac9824e
Author: Sławek Kapłoński <email address hidden>
Date: Sat May 20 22:14:49 2017 +0000

    Add more detailed info about supported QoS rule types

    This spec propose new API call to discover details about
    supported QoS rule type: which backend driver supports it
    and what parameters are supported by such driver.

    Change-Id: Id926170842ae4443749e5c188eec190b3045ff26
    Related-Bug: 1686035

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/475260

Changed in neutron:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-specs (master)

Fix proposed to branch: master
Review: https://review.openstack.org/477170

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-specs (master)

Reviewed: https://review.openstack.org/477170
Committed: https://git.openstack.org/cgit/openstack/neutron-specs/commit/?id=a40b46100f4e7e5955cde87593b529d4ec22e1ff
Submitter: Jenkins
Branch: master

commit a40b46100f4e7e5955cde87593b529d4ec22e1ff
Author: Sławek Kapłoński <email address hidden>
Date: Sat Jun 24 20:39:02 2017 +0000

    Update description of possible values in QoS rule types

    QoS backend drivers are using validators "type:range" and "type:values" to
    validate if given value is supported.
    Such possible values should be represented in different way when rule_type
    details are requested.
    This commit changes format of values which can be returned as result of such
    request.

    Change-Id: I460f7b2b265115120102e575d4040c0c5f5264f8
    Partial-Bug: 1686035

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/475260
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2cc547241c99b01e36fdc69a08c59f975b32c508
Submitter: Jenkins
Branch: master

commit 2cc547241c99b01e36fdc69a08c59f975b32c508
Author: Sławek Kapłoński <email address hidden>
Date: Mon Jun 19 06:35:25 2017 +0000

    New API call to get details of supported QoS rule type

    This commit adds new API call that allows to discover
    details about supported QoS rule type and its parameters
    by each of loaded backend drivers.

    DocImpact: New call to get details about supported
               rule_type for each loaded backend driver
    ApiImpact

    Change-Id: I2008e9d3e400dd717434fbdd2e693c9c5e34c3a4
    Closes-Bug: #1686035

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 11.0.0.0b3

This issue was fixed in the openstack/neutron 11.0.0.0b3 development milestone.

Akihiro Motoki (amotoki)
Changed in neutron:
milestone: none → pike-3
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.