Command openstack volume snapshot create does not correctly return help

[Anne Gentle]

On python-openstackclient 3.3.0, with credentials sourced, I get an error:

'NoneType' object has no attribute 'isdigit'

When typing openstack volume snapshot create.

I can get help from openstack volume snapshot create --help.

[Steve Martinelli (stevemar)]

Hmm, this may be fixed in 3.8.0... care to try that version?

In version 3.3.0 we only had "openstack snapshot create" (minus the volume) [1]

[1] https://github.com/openstack/python-openstackclient/blob/3.3.0/setup.cfg#L450

In newer versions we deprecated that and added the "volume" keyword [2]

[2] https://github.com/openstack/python-openstackclient/blob/master/setup.cfg#L497-L502

[Dean Troyer (dtroyer)]

This is still present in 3.8.1.

 $ os volume snapshot create
 'NoneType' object has no attribute 'isdigit'
 $ os --version
 openstack 3.8.1

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/440497

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/440497
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=1c49a1f01da73b8eed701809de88b408e738dfed
Submitter: Jenkins
Branch: master

commit 1c49a1f01da73b8eed701809de88b408e738dfed
Author: Huanxuan Ao <email address hidden>
Date: Wed Mar 8 10:01:16 2017 +0800

    Fix NoneType error for volume snapshot create command

    In volume snapshot command, <volume> is the same
    as <snapshot-name> when --volume is not specified,
    but <volume> cannot be None, so when <snapshot-name>
    is not specified (<snapshot-name> is None), a NoneType
    error appears.
    So make <snapshot-name> no longer optional, it should
    be always present.

    Change-Id: I3d9f10753a8ef601e70816421c160598e2cc811f
    Closes-bug: #1659894

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-openstackclient 3.10.0 release.