Replace "Display Name" by "Name" in volume list command

Bug #1657956 reported by Rui Chen on 2017-01-20
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
python-openstackclient
Fix Released
Undecided
Rui Chen

Bug Description

Current "volume list --name" command use "display_name" as search_opts to send to cinder API, and show the result table with "Display Name" column title in osc, cinder list API support "name" as search opts too, and there is "name" attribute in volume response body, so we can replace all "Display Name" by "Name" in order to keep "volume list" command consistent with other commands, like: server list, network list and so on, only use "Name" attribute for all objects.

cinder list API search opt
v1: display_name
v2: both display_name and name

cinder list API response
v1: display_name
v2: name

osc volume list search opt(current):
v1: display_name
v2: display_name

osc volume list column title(current):
v1: display_name
v2: display_name

Proposed change:

osc volume list search opt:
v1: display_name
v2: name

osc volume list column title:
v1: name
v2: name

Rui Chen (kiwik-chenrui) on 2017-01-20
Changed in python-openstackclient:
assignee: nobody → Rui Chen (kiwik-chenrui)
Rui Chen (kiwik-chenrui) on 2017-01-20
description: updated

Fix proposed to branch: master
Review: https://review.openstack.org/423081

Changed in python-openstackclient:
status: New → In Progress

Reviewed: https://review.openstack.org/436289
Committed: https://git.openstack.org/cgit/openstack/osc-lib/commit/?id=11b6e92d2d4f3b7e5578cb352b6f47d13206f8fd
Submitter: Jenkins
Branch: master

commit 11b6e92d2d4f3b7e5578cb352b6f47d13206f8fd
Author: Rui Chen <email address hidden>
Date: Mon Feb 20 17:14:12 2017 +0800

    Util methods for column name backward compatibility

    Add two util methods for handling column name backward compatibility,
    that can be used in commands of ShowOne and Lister class.

    Change-Id: I1fb62219b092346ea380099811cbd082cae5bafe
    Partial-Bug: #1657956

Reviewed: https://review.openstack.org/423081
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=6aceca218af7d1d2c708fde48f1a5f2b798bc421
Submitter: Jenkins
Branch: master

commit 6aceca218af7d1d2c708fde48f1a5f2b798bc421
Author: Rui Chen <email address hidden>
Date: Fri Jan 20 14:37:14 2017 +0800

    Replace "Display Name" by "Name" in volume list

    Current "volume list --name" command use "display_name" as search_opts
    to send to cinder API, and show the result table with "Display Name"
    column title in osc, cinder list API support "name" as search opts too,
    and there is "name" attribute in volume response body, so we can replace
    all "Display Name" by "Name" in order to keep "volume list" command
    consistent with other commands, like: server list, network list and so
    on, only use "Name" attribute for all objects.

    Support a mapping for volume list -c "Display Name" (Volume v1 and v2)
    and volume create/show -c "display_name" (Volume v1) for minimal
    backward compatibility until R release.

    Change-Id: I120be0118e7bb30093b4237c5eeb69a9eedef077
    Closes-Bug: #1657956
    Depends-On: I1fb62219b092346ea380099811cbd082cae5bafe

Changed in python-openstackclient:
status: In Progress → Fix Released

This issue was fixed in the openstack/python-openstackclient 3.12.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers