Functional test test_qos_rule_type_list broken

Bug #1653137 reported by Dean Troyer on 2016-12-29
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-openstackclient
Fix Released
Critical
Steve Martinelli

Bug Description

The functional test test_qos_rule_type_list is broken for all current OpenStack SDK releases (>= 0.9.10).

openstack --debug network qos rule type list
...
Network client initialized using OpenStack SDK: <openstack.network.v2._proxy.Proxy object at 0x109477510>
'Proxy' object has no attribute 'qos_rule_types'
Traceback (most recent call last):
  File "/Users/dtroyer/src/openstack/python-openstackclient/.tox/functional/lib/python2.7/site-packages/cliff/app.py", line 400, in run_subcommand
    result = cmd.run(parsed_args)
  File "/Users/dtroyer/src/openstack/python-openstackclient/.tox/functional/lib/python2.7/site-packages/osc_lib/command/command.py", line 41, in run
    return super(Command, self).run(parsed_args)
  File "/Users/dtroyer/src/openstack/python-openstackclient/.tox/functional/lib/python2.7/site-packages/cliff/display.py", line 112, in run
    column_names, data = self.take_action(parsed_args)
  File "/Users/dtroyer/src/openstack/python-openstackclient/openstackclient/network/v2/network_qos_rule_type.py", line 36, in take_action
    data = client.qos_rule_types()
AttributeError: 'Proxy' object has no attribute 'qos_rule_types'
clean_up ListNetworkQosRuleType: 'Proxy' object has no attribute 'qos_rule_types'
Traceback (most recent call last):
  File "/Users/dtroyer/src/openstack/python-openstackclient/.tox/functional/lib/python2.7/site-packages/osc_lib/shell.py", line 135, in run
    ret_val = super(OpenStackShell, self).run(argv)
  File "/Users/dtroyer/src/openstack/python-openstackclient/.tox/functional/lib/python2.7/site-packages/cliff/app.py", line 279, in run
    result = self.run_subcommand(remainder)
  File "/Users/dtroyer/src/openstack/python-openstackclient/.tox/functional/lib/python2.7/site-packages/osc_lib/shell.py", line 180, in run_subcommand
    ret_value = super(OpenStackShell, self).run_subcommand(argv)
  File "/Users/dtroyer/src/openstack/python-openstackclient/.tox/functional/lib/python2.7/site-packages/cliff/app.py", line 400, in run_subcommand
    result = cmd.run(parsed_args)
  File "/Users/dtroyer/src/openstack/python-openstackclient/.tox/functional/lib/python2.7/site-packages/osc_lib/command/command.py", line 41, in run
    return super(Command, self).run(parsed_args)
  File "/Users/dtroyer/src/openstack/python-openstackclient/.tox/functional/lib/python2.7/site-packages/cliff/display.py", line 112, in run
    column_names, data = self.take_action(parsed_args)
  File "/Users/dtroyer/src/openstack/python-openstackclient/openstackclient/network/v2/network_qos_rule_type.py", line 36, in take_action
    data = client.qos_rule_types()
AttributeError: 'Proxy' object has no attribute 'qos_rule_types'

Original review: https://review.openstack.org/#/c/355376/

Verified not working with OpenStack SDK 0.9.10, 0.9.11

Dean Troyer (dtroyer) on 2016-12-29
description: updated
prameswar (prameswar) on 2016-12-29
Changed in python-openstackclient:
assignee: nobody → prameswar (prameswar)
Steve Martinelli (stevemar) wrote :
Changed in python-openstackclient:
assignee: prameswar (prameswar) → Steve Martinelli (stevemar)
Changed in python-openstackclient:
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/419129
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=511b7880ea0dae6042426aac3743ac9941fc8db3
Submitter: Jenkins
Branch: master

commit 511b7880ea0dae6042426aac3743ac9941fc8db3
Author: Steve Martinelli <email address hidden>
Date: Wed Jan 11 15:45:19 2017 -0500

    unskip network qos rule type functional test

    with the SDK at 0.9.12 the below test fails with:

    'minimum_bandwidth' not in

    +-----------------+
    | Type |
    +-----------------+
    | dscp_marking |
    | bandwidth_limit |
    +-----------------+

    So remove 'minimum_bandwidth' from the asserted fields.

    Change-Id: I24ff691ae5a946d901afa763973305025829280b
    Closes-Bug: 1653137

Changed in python-openstackclient:
status: In Progress → Fix Released

This issue was fixed in the openstack/python-openstackclient 3.7.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers