When server create --volume used root device_name always 'vda'

Bug #1647406 reported by Nikita Gerasimov on 2016-12-05
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-openstackclient
Fix Released
Undecided
Nikita Gerasimov

Bug Description

openstackclient/compute/v2/server.py have hard-codded behavior to set for boot volume dev name 'vda' which is work not for all hypervisors.

https://github.com/openstack/python-openstackclient/blob/0ef8535036c3739d798fd5627ae142d121f20d42/openstackclient/compute/v2/server.py#L496

Instead of it we cat use block_device_mapping_v2 directly and use boot_index as replace for device_name

Dean Troyer (dtroyer) on 2017-01-25
Changed in python-openstackclient:
status: New → Confirmed
assignee: nobody → Dean Troyer (dtroyer)
assignee: Dean Troyer (dtroyer) → Nikita Gerasimov (nikita-gerasimov)

Reviewed: https://review.openstack.org/407111
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=95c8661f86e74c9d5217869a740da11350f1f0eb
Submitter: Jenkins
Branch: master

commit 95c8661f86e74c9d5217869a740da11350f1f0eb
Author: Nikita Gerasimov <email address hidden>
Date: Mon Dec 5 20:47:40 2016 +0300

    Switch server create to block_device_mapping_v2

    Current compute_client.servers.create() relies on block_device_mapping
    arg which is legacy[1]. "block_device_mapping" format require
    device_name which is leads to hard-coded hack in --volume key handler
    to KVM specific. "block_device_mapping_v2" format is more friendly
    to hypervisiors.
    Support of block_device_mapping_v2 appear in python-novaclient 2.16.0,
    openstackclient require at least 2.29.0

    Makes options --volume and --block-device-mapping work simultaneously.
    Appends --block-device-mapping data even if --volume used.
    After bug 1383338 only --volume was taken when both are used.

    [1]http://docs.openstack.org/developer/nova/block_device_mapping.html

    NOTE(dtroyer): I moved the new test_boot_from_volume() functional
    test to Ie51b1c375c5940856ec76a5770df3c6bd18a3eba to test our
    previous behaviour. The only changes required to support the new
    behaviour should be that the empty_volume is now attached in that test.

    Change-Id: I7bac3d870dd9ca404093142f8bce22a62e49180d
    Closes-Bug: 1647406
    Closes-Bug: 1497845

Changed in python-openstackclient:
status: Confirmed → Fix Released

This issue was fixed in the openstack/python-openstackclient 3.8.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers