cinder only supports deriving a user and project id from auth context

[Steve Martinelli]

In the python bindings for creating a volume there are arguments for specifying a user_id and project_id [1], this exists for many resources (volumes and consistency groups).

        :param user_id: User id derived from context
        :param project_id: Project id derived from context

These are then added to the request body. However, as the docstring indicates, it seems cinder API will never make use of these values. The user_id and project_id is always derived from the auth context [2]. Additionally, the cinder CLI also does not provide a user id or project id to make use of these arguments.

* Why supply these arguments in cinderclient if they are never used?

* Was there ever a plan to allow an admin to create a volume (or cinder resource) for someone else? As it stands now, that would not be possible.

[1] https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v3/volumes.py#L239-L240

[2] https://github.com/openstack/cinder/blob/a15459a27777e98599d70392191b0a6f0288ff34/cinder/context.py#L118

[Steve Martinelli (stevemar)]

Adding OSC since we (incorrectly) assumed that the user_id and project_id arguments were being used.

[John Griffith (john-griffith)]

I think there was a time when there was some consideration for doing something like in fact admin or special volumes being created. That never really happened, so we don't need to worry about that.

The only other place that I can think of that might have had some intent here was some of the nested tenant stuff (tenant groups etc) but again the way it is right now wouldn't be much use for that either. Seems to me that these can be removed.

[Steven Pisarski (spisarski)]

I've encountered the same problem using the cinder v2 & v3 with the Python APIs found in python-cinderclient currently on v 3.2.0.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/585128

[OpenStack Infra (hudson-openstack)]

Change abandoned by Rajat Dhasmana (<email address hidden>) on branch: master
Review: https://review.openstack.org/585128
Reason: Patch already merged

https://review.openstack.org/#/c/573622/2

[Rajat Dhasmana (whoami-rajat)]

Patch already merged,

https://review.openstack.org/#/c/573622/2