Unit tests fail if using os-client-config after commit 8b7859e21e64027d20f158737bbf70bbe409b847

Bug #1630694 reported by Javier Peña
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-openstackclient
Fix Released
Undecided
Unassigned

Bug Description

If I try to run the unit tests for python-openstackclient using the current master version of os-cloud-config (rather than a released version), I get the following errors repeatedly:

Traceback (most recent call last):
  File "/tmp/python-openstackclient/openstackclient/tests/unit/integ/cli/test_shell.py", line 208, in test_shell_args_verify
    self.assertEqual(len(self.requests_mock.request_history), 2)
  File "/tmp/kk/lib/python2.7/site-packages/testtools/testcase.py", line 411, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/tmp/kk/lib/python2.7/site-packages/testtools/testcase.py", line 498, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: 0 != 2
======================================================================
FAIL: openstackclient.tests.unit.integ.cli.test_shell.TestIntegShellCliV3Prompt.test_shell_callback
tags: worker-1
----------------------------------------------------------------------
Empty attachments:
  stdout

stderr: {{{load_auth_plugin() takes exactly 2 arguments (3 given)}}}

https://github.com/openstack/os-client-config/commit/8b7859e21e64027d20f158737bbf70bbe409b847 seems to be involved. It creates a load_auth_plugin() method in class OpenStackConfig, with 3 arguments. Commit 14dbfe44741b65c9e0514a34669f52de8629b1c0 to python-openstackclient creates another load_auth_plugin() method, with 2 arguments, in class OSC_Config, which derives from OpenStackConfig.

Revision history for this message
Javier Peña (jpena-c) wrote :

Fixed on the os-client-config side via https://review.openstack.org/385606

Changed in python-openstackclient:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.