python-openstackclient

tripleoclient unit tests failing with latest openstackclient

Bug #1623179 reported by Ben Nemec on 2016-09-13

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
python-openstackclient	Invalid	Undecided	Unassigned
tripleo	Fix Released	Critical	Ben Nemec
Newton	Fix Released	Critical	Unassigned	tripleo newton-rc2 "newton-rc2"

Bug Description

tripleoclient imports openstackclient.tests.utils, which got moved in https://github.com/openstack/python-openstackclient/commit/39839def2e356e8d145be89380c73a71423cf06d

This breaks the unit tests. I don't know whose bug it is - should tripleoclient not be using that module or should it not have been moved? Either way we need a fix because it's blocking any new builds of tripleoclient.

See original description

Tags:

Ben Nemec (bnemec) on 2016-09-13

description:

updated

Revision history for this message

Dean Troyer (dtroyer) wrote on 2016-09-13:

tripleoclient should be using osc-lib for that rather than openstackclient

Revision history for this message

Dean Troyer (dtroyer) wrote on 2016-09-13:

A bit more detail is in http://docs.openstack.org/developer/osc-lib/transition.html in making the transition to not using OpenStackClient as a dependency in plugins.

Changed in python-openstackclient:
status:	New → Invalid

Revision history for this message

Brad P. Crochet (brad-9) wrote on 2016-09-14:

This should be fixed by https://review.openstack.org/#/c/335460/

Revision history for this message

Ben Nemec (bnemec) wrote on 2016-09-14:

Unfortunately it's not 100% fixed. There was one reference to openstackclient.tests missed. I'm about to push a patch.

Changed in tripleo:
assignee:	nobody → Ben Nemec (bnemec)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-14: Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/370401

Changed in tripleo:
status:	Triaged → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-15: Fix merged to python-tripleoclient (master)

Reviewed: https://review.openstack.org/370401
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=6be014273b0cbcea0fef951c23e39b2348c8a328
Submitter: Jenkins
Branch: master

commit 6be014273b0cbcea0fef951c23e39b2348c8a328
Author: Ben Nemec <email address hidden>
Date: Wed Sep 14 20:43:43 2016 +0000

Remove one last reference to openstackclient.tests

Most of these were moved to osc_lib already, but this one was
missed. Hopefully this will get the package build working again.

Change-Id: Ie2fa8dc012bccbcc54a4ae0a82d1a5a7ef2a35af
Closes-Bug: 1623179

Changed in tripleo:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-20: Fix proposed to python-tripleoclient (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/373435

Julie Pichon (jpichon) on 2016-09-20

tags:

added: newton-backport-potential

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-20: Fix merged to python-tripleoclient (stable/newton)

Reviewed: https://review.openstack.org/373435
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=c1619c3588bc33ffe798db0757419310be917be3
Submitter: Jenkins
Branch: stable/newton

commit c1619c3588bc33ffe798db0757419310be917be3
Author: Ben Nemec <email address hidden>
Date: Wed Sep 14 20:43:43 2016 +0000

Remove one last reference to openstackclient.tests

Most of these were moved to osc_lib already, but this one was
missed. Hopefully this will get the package build working again.

    Change-Id: Ie2fa8dc012bccbcc54a4ae0a82d1a5a7ef2a35af
    Closes-Bug: 1623179
    (cherry picked from commit 6be014273b0cbcea0fef951c23e39b2348c8a328)