latest osc-lib breaks osc gate

Bug #1599333 reported by Steve Martinelli
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-openstackclient
Fix Released
Medium
Steve Martinelli

Bug Description

v0.2.1 of osc-lib broke the osc py27 gate: http://logs.openstack.org/88/300388/25/check/gate-python-openstackclient-python27/d27a108/testr_results.html.gz

these breaks are due to the re-arranging of logic in find_resources, and are only seen in tests that mock that method. this change in the osc-lib release will not impact end-users.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-openstackclient (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/337927

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-openstackclient (master)

Reviewed: https://review.openstack.org/337927
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=72a82b2794912041173290fc71507f3768a62c0b
Submitter: Jenkins
Branch: master

commit 72a82b2794912041173290fc71507f3768a62c0b
Author: Steve Martinelli <email address hidden>
Date: Tue Jul 5 20:24:31 2016 -0400

    skip failing tests due to bug 1599333 is fixed

    latest osc-lib breaks some of the tests, skip them for now
    so we can continue to merge patches that are already approved.

    Change-Id: I433190e9f763bea1df3135612b281d925745f884
    Related-Bug: 1599333

Revision history for this message
Steve Martinelli (stevemar) wrote :
Changed in python-openstackclient:
importance: Undecided → Medium
assignee: nobody → Steve Martinelli (stevemar)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-openstackclient (master)

Reviewed: https://review.openstack.org/339326
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=9f09d8c5d43141b683dd6b5258fa94799571a843
Submitter: Jenkins
Branch: master

commit 9f09d8c5d43141b683dd6b5258fa94799571a843
Author: Steve Martinelli <email address hidden>
Date: Thu Jul 7 22:41:07 2016 -0400

    Unskip tests caused by bug 1599333

    There is now a second .get() call in osc_lib.utils.find_resources.
    These tests were failing because they only mocked a single access
    call to .get(). Ensure there are two calls to .get(), with the
    first one raising an exception.

    Change-Id: Idd2ad4a27a6db5bee633cc37a1042dbb0a57aa71
    Closes-Bug: #1599333

Changed in python-openstackclient:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/python-openstackclient 3.0.0

This issue was fixed in the openstack/python-openstackclient 3.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.