Loading of auth plugin options uses "dest" instead of "name"

Bug #1596937 reported by Alvaro Lopez
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-openstackclient
Fix Released
Undecided
Alvaro Lopez

Bug Description

When loading the auth plugin options, the code uses "dest" instead of "name" for creating the osc options. Some plugins may use different names for the option and the destination name, so this will make these plugins not work as expected (for example, the option "openid-scope" is stored in "scope").

Revision history for this message
Alvaro Lopez (aloga) wrote :
Changed in python-openstackclient:
assignee: nobody → Alvaro Lopez (aloga)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-openstackclient (master)

Change abandoned by Dean Troyer (<email address hidden>) on branch: master
Review: https://review.openstack.org/335003
Reason: This is now handled in osc-lib with https://review.openstack.org/339243

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to osc-lib (master)

Reviewed: https://review.openstack.org/339243
Committed: https://git.openstack.org/cgit/openstack/osc-lib/commit/?id=abc824010a90ceb84ae94cd5755ef9e3d3635eae
Submitter: Jenkins
Branch: master

commit abc824010a90ceb84ae94cd5755ef9e3d3635eae
Author: Dean Troyer <email address hidden>
Date: Thu Jul 7 16:24:03 2016 -0500

    Generate auth plugin options based on the name

    When loading the auth plugin options, the conversion from "-" into "_"
    is done based on the "dest" attribute of the option, instead of using
    its name. This makes that if a plugin defines an option with a different
    destination the wrong option will be created in osc, therefore the
    option won't be passed properly to the plugin class.

    Backported from OSC Iac7346dd57f8ea4f5b956b9bdf9f70d9494b63f8
    (https://review.openstack.org/#/c/335003/)

    Co-Authored-By: Alvaro Lopez Garcia <email address hidden>
    Closes-Bug: #1596937
    Change-Id: Iab84c918f82d0313d2562ebc0655bf11d24175c9

Changed in python-openstackclient:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/osc-lib 0.3.0

This issue was fixed in the openstack/osc-lib 0.3.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.