``volume type unset`` does not accept multiple "--property " arguments

[sunyajing]

volume type unset --property only works on one argument, failed when unset multiple --property arguments.

[Steve Martinelli (stevemar)]

Looks like neither accepts multiple args:

v1:
https://github.com/openstack/python-openstackclient/blob/master/openstackclient/volume/v1/volume_type.py#L205-L206

v2:
https://github.com/openstack/python-openstackclient/blob/master/openstackclient/volume/v2/volume_type.py#L304-L309

[Rui Chen (kiwik-chenrui)]

cinderclient volume_type.unset_keys() only delete the first key even if multiple keys are applied.

The response of manager._delete() is tuple object, it is not "None" even if the deleting success, so the batch operation would be broken when the first key is deleted successfully, I think it's a cinderclient bug, not osc bug.

https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v3/volume_types.py#L73-L74

[aohuanxuan (huanxuan-ao)]

Yea, it is a problem in cinderclient, I fixed it in the former patch but I abandoned it :(
https://review.openstack.org/#/c/325801/
It would be nice if you continue to finish this work. Thanks :)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/335327

[Rui Chen (kiwik-chenrui)]

Add functional test cases to avoid the issue in OSC.

https://review.openstack.org/#/c/335338/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/335327
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=bc5ddf1e6a1e396c3d8a29b42369f48b0b5f2302
Submitter: Jenkins
Branch: master

commit bc5ddf1e6a1e396c3d8a29b42369f48b0b5f2302
Author: Rui Chen <email address hidden>
Date: Wed Jun 29 11:24:41 2016 +0800

    Fix batch deleting issue in volume_type.unset_keys()

    cinderclient volume_type.unset_keys() only delete the first key even if
    multiple keys are applied. The response of manager._delete() is tuple object,
    it is not "None" if the deleting success, so the batch operation would
    be broken when the first key is deleted successfully. The patch fix this
    issue.

    Change-Id: I60378a32cdc52aacdf869d69b246dec7eb6cdb77
    Closes-Bug: #1596511

[Steve Martinelli (stevemar)]

Unassigning due to inactivity

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-cinderclient 1.9.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/335338
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=8d59b31c72468d82cbe79a6cf24df28fb3b6cf06
Submitter: Jenkins
Branch: master

commit 8d59b31c72468d82cbe79a6cf24df28fb3b6cf06
Author: Rui Chen <email address hidden>
Date: Wed Jun 29 14:43:38 2016 +0800

    Add functional tests for unset multiple volume type props

    CinderClient bug/1596511 cause that OSC can't unset multiple
    properties of volume type, obviously no functional test case
    cover the part of logic in OSC, that make the issue raising,
    the patch add functional test cases for this scenario.

    Change-Id: I42cf9ac8cc72ccc2f1208926d8faf7b80ee2d288
    Partial-Bug: #1596511
    Depends-On: I60378a32cdc52aacdf869d69b246dec7eb6cdb77

[Steve Martinelli (stevemar)]

I think we can close this out for OSC now?

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-cinderclient 1.9.0 release.