ensure all delete commands can take multiple objects

Bug #1592906 reported by Steve Martinelli on 2016-06-15
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-openstackclient
Fix Released
Medium
aohuanxuan

Bug Description

as summed up here: https://twitter.com/iamjkeating/status/743123267607617536

all our delete commands should take multiple resources

  `openstack foo delete bar1 bar2 bar3 ...`

i don't have a summary of which commands have it and which don't

Jesse Keating (jesse-keating) wrote :

Nova commands appear to take multiple (eg server delete), whereas Neutron ones don't (eg security group delete). I don't have any more data than this right now though.

Steve Martinelli (stevemar) wrote :

FWIW, https://review.openstack.org/#/c/328689/ just merged which added multi-delete support for a bunch of networking commands

Steve Martinelli (stevemar) wrote :

The following is a list of modules that need to support multi-delete:

compute/v2/aggregate
compute/v2/flavor
compute/v2/keypair
compute/v2/service
identity/v2_0/ec2creds
identity/v2_0/endpoint
identity/v2_0/service
identity/v3/consumer
identity/v3/credential
identity/v3/domain
identity/v3/ec2creds
identity/v3/endpoint
identity/v3/federation_protocol
identity/v3/identity_provider
identity/v3/mapping
identity/v3/policy
identity/v3/region
identity/v3/service_provider
identity/v3/service
network/v2/subnet
network/v2/subnet_pool
volume/v1/volume_type
volume/v2/volume_type

Tang Chen (tangchen) on 2016-06-16
Changed in python-openstackclient:
assignee: nobody → aohuanxuan (huanxuan-ao)

Fix proposed to branch: master
Review: https://review.openstack.org/330314

Changed in python-openstackclient:
status: New → In Progress

Reviewed: https://review.openstack.org/330314
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=041ea4978b94149d5037b5afc7743db939b75331
Submitter: Jenkins
Branch: master

commit 041ea4978b94149d5037b5afc7743db939b75331
Author: Huanxuan Ao <email address hidden>
Date: Thu Jun 16 13:09:27 2016 +0800

    Support bulk deletion for delete commands in networkv2

    This patch support bulk deletion for delete commands below:
    1.subnet delete
    2.subnet pool delete

    Up to now, all the delete commands in networkv2 support bulk deletion.

    Change-Id: I63f6d1d02bad1fcc26e72b7028b53958a68ce2dc
    Partially-Implements: blueprint multi-argument-network
    Partial-Bug: #1592906

Changed in python-openstackclient:
importance: Undecided → Medium
Steve Martinelli (stevemar) wrote :

patch for volume commands: https://review.openstack.org/#/c/330742/

Reviewed: https://review.openstack.org/331544
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=640014fa91b939e802f261346473d3ec025f2acb
Submitter: Jenkins
Branch: master

commit 640014fa91b939e802f261346473d3ec025f2acb
Author: Huanxuan Ao <email address hidden>
Date: Mon Jun 20 15:42:40 2016 +0800

    Support bulk deletion for "flavor/aggregate delete"

    Support bulk deletion and error handling for "aggregate delete"
    and "flavor delete" commands.

    Change-Id: I3f6105cbeeab1c9f8cd571c63ce0e7ac3d4252b3
    Partially-Implements: blueprint multi-argument-compute
    Partial-Bug: #1592906

Reviewed: https://review.openstack.org/330742
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=4e62e1e2e18cb93ba0f88bff8727182b1002de4b
Submitter: Jenkins
Branch: master

commit 4e62e1e2e18cb93ba0f88bff8727182b1002de4b
Author: Steve Martinelli <email address hidden>
Date: Thu Jun 16 14:25:33 2016 -0400

    support multi-delete for volume-type

    Added the ability to delete multiple volume types at once. Note
    there are no unit tests exist for v1 volume-types, so instead
    a functional test was created.

    Partial-Bug: #1592906
    Change-Id: I99f3f22901ab35252b91a3072b14de7d19cb17ca

Reviewed: https://review.openstack.org/333109
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=6df09fd377f872388d4f855b001a6578ae6fba46
Submitter: Jenkins
Branch: master

commit 6df09fd377f872388d4f855b001a6578ae6fba46
Author: sunyajing <email address hidden>
Date: Thu Jun 23 12:55:54 2016 +0800

    Support multi-delete for commands in identity V2

    Commands are "ec2 credentials delete", "service delete", "endpoint delete".
    Also update their unit tests and functional tests.

    Partial-Bug: #1592906
    Change-Id: I1a0b7160b803a523646d09d030e6f112c81c4c24

Reviewed: https://review.openstack.org/334307
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=af7ab03693a5708102cf6746563da289e4c1e3b7
Submitter: Jenkins
Branch: master

commit af7ab03693a5708102cf6746563da289e4c1e3b7
Author: Huanxuan Ao <email address hidden>
Date: Mon Jun 27 11:04:05 2016 +0800

    Support bulk deletion for delete commands in computev2

    Support bulk deletion and error handling for "keypair delete"
    and "service delete" commands in computev2.
    Up to now, all the delete commands in computev2 support bulk
    deletion.

    Change-Id: I6d5c960e9716188e56615514d0921618a15a88ec
    Partially-Implements: blueprint multi-argument-compute
    Partial-Bug: #1592906

Reviewed: https://review.openstack.org/340681
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=60639d76a742852e18f9e2889c480be95596c268
Submitter: Jenkins
Branch: master

commit 60639d76a742852e18f9e2889c480be95596c268
Author: Huanxuan Ao <email address hidden>
Date: Tue Jul 12 12:44:55 2016 +0800

    Support bulk deletion for delete commands in identityv3

    Support bulk deletion for delete commands in the list below
    identity/v3/consumer
    identity/v3/credential
    identity/v3/domain
    identity/v3/ec2creds
    identity/v3/endpoint
    identity/v3/federation_protocol
    identity/v3/identity_provider
    identity/v3/mapping
    identity/v3/policy
    identity/v3/region
    identity/v3/service_provider
    identity/v3/service

    The unit test in identityv3 need to be refactored, so I add
    some functional tests instead. I will add all unit tests at
    one time after the refactor completed.

    Change-Id: I82367570f59817b47c87b6c7bfeae95ccfe5c50e
    Closes-Bug: #1592906

Changed in python-openstackclient:
status: In Progress → Fix Released

This issue was fixed in the openstack/python-openstackclient 3.0.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers