No error handling if the property type don't match "key=value"
Bug #1589935 reported by
aohuanxuan
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| python-openstackclient |
Fix Released
|
Undecided
|
aohuanxuan | ||
Bug Description
Normally, we set a property using the type "key=value", but if the input don't match this type, there is no error handling, just return None. This may confuse the users.
| Changed in python-openstackclient: | |
| assignee: | nobody → aohuanxuan (huanxuan-ao) |
| Changed in python-openstackclient: | |
| status: | New → In Progress |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to python-openstackclient (master) | #1 |
| Changed in python-openstackclient: | |
| status: | In Progress → Fix Released |
Revision history for this message
| Doug Hellmann (doug-hellmann) wrote Fix included in openstack/python-openstackclient 3.0.0 | #2 |
To post a comment you must log in.
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit cf122397733b879
Author: Huanxuan Ao <email address hidden>
Date: Tue Jun 7 16:41:21 2016 +0800
Error handling for KeyValueAction class.
The set --property command requires that the input match
the "key=value" type, but if the type don't match, the return
value will be None, and the command still can be implemented
successfully, this may confuse the users. I think we should
raise exception if the argument type don't match "key=value".
So I make some changes in KeyValueAction class in this patch.
Change-Id: I14e64922faa7e0
Closes-Bug: #1589935