volume functional test occasionally fails

[Steve Martinelli]

Looks like the functional tests for volume type is failing every now and then with an unknown argument "--private". The source code indicates that this parameter is in v2 and not v1, which makes me think the functional tests should look at OS_VOLUME_API_VERSION before running.

2016-06-07 00:09:30.900 | 2016-06-07 00:09:30.895 | setUpClass (functional.tests.volume.v2.test_volume_type.VolumeTypeTests)
2016-06-07 00:09:30.920 | 2016-06-07 00:09:30.897 | ------------------------------------------------------------------------
2016-06-07 00:09:30.920 | 2016-06-07 00:09:30.899 |
2016-06-07 00:09:30.920 | 2016-06-07 00:09:30.900 | Captured traceback:
2016-06-07 00:09:30.921 | 2016-06-07 00:09:30.902 | ~~~~~~~~~~~~~~~~~~~
2016-06-07 00:09:30.921 | 2016-06-07 00:09:30.905 | Traceback (most recent call last):
2016-06-07 00:09:30.921 | 2016-06-07 00:09:30.906 | File "functional/tests/volume/v2/test_volume_type.py", line 29, in setUpClass
2016-06-07 00:09:30.921 | 2016-06-07 00:09:30.908 | 'volume type create --private ' + cls.NAME + opts)
2016-06-07 00:09:30.921 | 2016-06-07 00:09:30.910 | File "functional/common/test.py", line 53, in openstack
2016-06-07 00:09:30.922 | 2016-06-07 00:09:30.911 | return execute('openstack ' + cmd, fail_ok=fail_ok)
2016-06-07 00:09:30.922 | 2016-06-07 00:09:30.913 | File "functional/common/test.py", line 42, in execute
2016-06-07 00:09:30.922 | 2016-06-07 00:09:30.915 | result_err)
2016-06-07 00:09:30.922 | 2016-06-07 00:09:30.917 | tempest.lib.exceptions.CommandFailed: Command 'openstack volume type create --private 8fd8c80832944e61b31c033c987b0d29 -f value -c name' returned non-zero exit status 2.
2016-06-07 00:09:30.923 | 2016-06-07 00:09:30.918 | stdout:
2016-06-07 00:09:30.926 | 2016-06-07 00:09:30.920 |
2016-06-07 00:09:30.927 | 2016-06-07 00:09:30.921 | stderr:
2016-06-07 00:09:30.928 | 2016-06-07 00:09:30.923 | usage: openstack volume type create [-h] [-f {json,shell,table,value,yaml}]
2016-06-07 00:09:30.930 | 2016-06-07 00:09:30.925 | [-c COLUMN] [--noindent] [--prefix PREFIX]
2016-06-07 00:09:30.932 | 2016-06-07 00:09:30.927 | [--max-width <integer>]
2016-06-07 00:09:30.948 | 2016-06-07 00:09:30.928 | [--property <key=value>]
2016-06-07 00:09:30.948 | 2016-06-07 00:09:30.930 | <name>
2016-06-07 00:09:30.948 | 2016-06-07 00:09:30.932 | openstack volume type create: error: unrecognized arguments: --private

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/330067

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/330067
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=09b783ad3e5051564bf6321feace3b65739febbf
Submitter: Jenkins
Branch: master

commit 09b783ad3e5051564bf6321feace3b65739febbf
Author: Richard Theis <email address hidden>
Date: Wed Jun 15 10:31:26 2016 -0500

    Fix volume functional tests

    The volume v2 functional tests occasionally fail with
    "unrecognized arguments: --private". This appears to occur when
    volume v1 and volume v2 functional tests are run at the same time
    when one or more of the tests do not set OS_VOLUME_API_VERSION
    appropriately.

    This patch also fixes a timing issue seen when running the
    tests locally due to a missing wait and moves the snapshot
    test to volume v2 since it was written for v2.

    Change-Id: I9c9863fe1aef81b0564920f36452c6f27211d5ba
    Closes-Bug: #1589793

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/python-openstackclient 3.0.0 release.