The wrong NAME_ATTR cause find() by name failure in ServerGroupsManager

Bug #1563301 reported by Rui Chen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-novaclient
Fix Released
Undecided
Rui Chen

Bug Description

Code base:

stack@szxbzci0004 ~/python-novaclient/novaclient (master) $ git log -1
commit 6aea33c79f67456a202e8c89cda22c9f1303daa3
Merge: 5f6d731 c5272b3
Author: Jenkins <email address hidden>
Date: Fri Mar 25 19:24:53 2016 +0000

    Merge "Adding tox support for bandit"

Finding by specify server group name failed in ServerGroupsManager.find(), ServerGroup.NAME_ATTR is "server_group_name" currently, but NAME_ATTR should be "name", because only "name" attribute exists in ServerGroup object, not "server_group_name".

Rui Chen (kiwik-chenrui)
Changed in python-novaclient:
assignee: nobody → Rui Chen (kiwik-chenrui)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/299093

Changed in python-novaclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/299093
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=51306fc4c925e48d7904b3b56303bb71bb80610e
Submitter: Jenkins
Branch: master

commit 51306fc4c925e48d7904b3b56303bb71bb80610e
Author: Rui Chen <email address hidden>
Date: Wed Mar 30 10:20:52 2016 +0800

    Fix ServerGroup.NAME_ATTR

    Finding by specify server group name failed in ServerGroupsManager.find(),
    ServerGroup.NAME_ATTR is "server_group_name" currently, but NAME_ATTR
    should be "name", because only "name" attribute exists in ServerGroup
    object, not "server_group_name".

    Change-Id: Id6b7676d14e6283d856a069da5ff287dc3228386
    Closes-Bug: #1563301

Changed in python-novaclient:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/python-novaclient 4.0.0

This issue was fixed in the openstack/python-novaclient 4.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.