Add "floating ip associate/disassociate"

Bug #1560297 reported by Tang Chen on 2016-03-22
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-openstackclient
Fix Released
Wishlist
Sindhu Devale

Bug Description

Add "floating ip associate/disassociate" commands to OSC.

Tang Chen (tangchen) on 2016-03-22
Changed in python-openstackclient:
assignee: nobody → Tang Chen (tangchen)
Tang Chen (tangchen) wrote :

Waiting for the rework of "ip floating xxx" commands.

https://review.openstack.org/#/c/291894/

Steve Martinelli (stevemar) wrote :

Automatically unassigning due to inactivity.

Changed in python-openstackclient:
assignee: Tang Chen (tangchen) → nobody
summary: - Floating ip and fixed ip mapping using SDK
+ Add "floating ip associate/disassociate"
Changed in python-openstackclient:
status: New → Confirmed
importance: Undecided → Wishlist
Richard Theis (rtheis) on 2016-08-19
tags: added: network
Changed in python-openstackclient:
assignee: nobody → Sindhu Devale (sindhu-devale-3)
Tang Chen (tangchen) wrote :

Hi Sindhu,

I think this bug has been fixed. Please refer to:
https://github.com/openstack/python-openstackclient/blob/master/openstackclient/compute/v2/server.py#L207

AddFloatingIP, RemoveFloatingIP, AddFixedIP, RemoveFixedIP.

Richard Theis (rtheis) wrote :

Hi Tang, I think that the use case missing is for "neutron floatingip-associate" and "neutron floatingip-disassociate". I think we need a couple "openstack floating ip *" commands for this.

@richard, I think it is implemented unless you want it exactly as neutron binding fips to port,

I think server is better, admin does not have to worry about port. but if its neutron equivalent is needed then definitely we should add a command to cover binding fip to ports case, but afaik i don't think it is needed we only associate fips to nova instances. please correct if I missed anything

(fip) == floatingip

Richard Theis (rtheis) wrote :

You can launch instances by providing a port. This leads to the use case of associating the fip to a port then launching the instance. I think we should support this.

Fix proposed to branch: master
Review: https://review.openstack.org/383025

Changed in python-openstackclient:
status: Confirmed → In Progress
Rui Chen (kiwik-chenrui) wrote :

Yes, I think we should support it in OSC, my colleagues and I had used the neutron floating ip associate commands, now we prepare to switch to OSC.

Reviewed: https://review.openstack.org/383025
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=763c8c5670f238920398165e670592e006213f32
Submitter: Jenkins
Branch: master

commit 763c8c5670f238920398165e670592e006213f32
Author: Sindhu Devale <email address hidden>
Date: Thu Oct 6 10:01:59 2016 -0500

    "floating ip set/unset port" for OSC

    Implements Neutron feature of floating ip associate/disassociate
    into OpenStack Client.

    Previously, network.find_ip() function only supported to
    search floating ip by UUID. Hence, _find_floating_ip()
    function is used in floating_ip.py, to search fip both by UUID
    and ip_address. [1] adds the ability to find fip object using both UUID
    and ip_address. This functionality however, won't be available until
    the SDK is released. Hence, we continue to use _find_floating_ip()
    method, which was cleaned up by [2] to remove the use of ip_cache.
    Once, the SDK is released, we will remove all the usage of
    _find_floating_ip() method and instead only use network.find_ip().

    [1] https://review.openstack.org/#/c/449879/2
    [2] https://review.openstack.org/#/c/447938/

    Change-Id: I6c5222287c46ca42365917d2deae70bdb626347
    Co-Authored-By: Reedip<email address hidden>
    Co-Authored-By: RuiChen<email address hidden>
    Closes-Bug: #1560297

Changed in python-openstackclient:
status: In Progress → Fix Released

This issue was fixed in the openstack/python-openstackclient 3.10.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Related blueprints