Rework of commands with multiple REST API calls to handle exception

Bug #1556719 reported by Tang Chen on 2016-03-14
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-openstackclient
Fix Released
Medium
Tang Chen

Bug Description

There was a BP to improve OSC commands to accept multiple servers.
https://blueprints.launchpad.net/python-openstackclient/+spec/cmd-with-multi-servers

Similar things could be done to many other commands. But since it would be multiple REST API calls, and we have not clarify how to handle exceptions when error happens in the middle of the calls.

Dean has posted a doc (doc/source/command-errors.rst) to clarify the behaviour of commands with multiple REST API calls.
https://review.openstack.org/#/c/290785/

So we need to rework all commands with multiple API calls to follow the rules.

Tang Chen (tangchen) on 2016-03-14
Changed in python-openstackclient:
assignee: nobody → Tang Chen (tangchen)
Tang Chen (tangchen) on 2016-03-14
description: updated

Fix proposed to branch: master
Review: https://review.openstack.org/293997

Changed in python-openstackclient:
status: New → In Progress

Reviewed: https://review.openstack.org/293997
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=56f9227063cb86594600ccc80c661101f0f0c2c8
Submitter: Jenkins
Branch: master

commit 56f9227063cb86594600ccc80c661101f0f0c2c8
Author: Tang Chen <email address hidden>
Date: Mon Mar 14 14:03:04 2016 +0800

    Enhance exception handling for "network delete" command

    This patch rework "network delete" command following the
    rules in doc/source/command-errors.rst.

    In "network delete" command, there are multiple REST API
    calls, and we should make as many of them as possible.
    And log error for each one, give a better error message.
    Also return a non-zero exit code.

    Change-Id: I39ae087dd7bd08d049d513abfa6c5cab2bd13b2b
    Partial-Bug: #1556719

Steve Martinelli (stevemar) wrote :

I think this has mostly been resolved -- we reworked a bunch of delete commands. Let's file bugs for individual commands that have errors

Changed in python-openstackclient:
status: In Progress → Fix Released
importance: Undecided → Medium
tags: added: mitaka-backport-potential
tags: removed: mitaka-backport-potential
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers