useless 'u' in the return info of "openstack aggregate show"

[hgangwx]

[Summary]
useless 'u' in the return info of "openstack aggregate show"

[Topo]
devstack all-in-one node

[Description and expect result]
no useless 'u' in the return info of "openstack aggregate show"

[Reproduceable or not]
reproduceable

[Recreate Steps]
1) useless 'u' for metadata when creating an aggregate:
root@45-59:/opt/stack/devstack# openstack aggregate create
--zone bbb --property abc=1 agg3
+-------------------+----------------------------------------------+
| Field | Value |
+-------------------+----------------------------------------------+
| availability_zone | bbb |
| created_at | 2016-01-26T11:07:16.000000 |
| deleted | False |
| deleted_at | None |
| hosts | [] |
| id | 3 |
| metadata | {u'abc': u'1', u'availability_zone': u'bbb'} |
| name | agg3 |
| updated_at | None |
+-------------------+----------------------------------------------+
root@45-59:/opt/stack/devstack#

2)useless 'u' for properties when show an aggregate:
root@45-59:/opt/stack/devstack# openstack aggregate show agg3
+-------------------+----------------------------+
| Field | Value |
+-------------------+----------------------------+
| availability_zone | bbb |
| created_at | 2016-01-26T11:07:16.000000 |
| deleted | False |
| deleted_at | None |
| hosts | [] |
| id | 3 |
| name | agg3 |
| properties | {u'abc': u'1'} |
| updated_at | None |
+-------------------+----------------------------+
root@45-59:/opt/stack/devstack#

3)useless 'u' for hosts when add host into an aggregate:
root@45-59:~# openstack aggregate add host agg3 45-59
+-------------------+----------------------------------------------+
| Field | Value |
+-------------------+----------------------------------------------+
| availability_zone | bbb |
| created_at | 2016-01-26T11:07:16.000000 |
| deleted | False |
| deleted_at | None |
| hosts | [u'45-59'] |
| id | 3 |
| metadata | {u'abc': u'1', u'availability_zone': u'bbb'} |
| name | agg3 |
| updated_at | None |
+-------------------+----------------------------------------------+
root@45-59:~#

[Configration]
reproduceable bug, no need

[logs]
reproduceable bug, no need

[Root cause anlyze or debug inf]
reproduceable bug

[Attachment]
None

[Pallavi (p-pallavi)]

Hi,

    I reproduced the bug as mentioned above and could see the 'u' in the output. On debugging, i find that while printing the aggregate data, if the value is a dict or list, it needs to be converted into Json format str.

    I made the below change in the file /usr/local/lib/python2.7/dist-packages/cliff/formatters/table.py such that if the value is dict or list then it is properly formatted and gets printed in the output.

     if isinstance(value, (dict, list)):
         value = jsonutils.dumps(value)

  Kindly let me know your comments on this.

Thanks & Regards,
Pallavi.

[Sean Dague (sdague)]

Not a nova bug, this is completely in the display layer for novaclient

[Neetu Jain (nutshi)]

its in openstackclient not in novaclient

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/281592

[Steve Martinelli (stevemar)]

Automatically unassigning due to inactivity.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: feature/osc4
Review: https://review.openstack.org/493814

[OpenStack Infra (hudson-openstack)]

Change abandoned by Rui Chen (<email address hidden>) on branch: master
Review: https://review.openstack.org/445794
Reason: Recommit the patch on feature/osc4 branch, close this.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/493814
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=ff9bd34b3c63c22c96d7a0711939828a38f003d8
Submitter: Jenkins
Branch: feature/osc4

commit ff9bd34b3c63c22c96d7a0711939828a38f003d8
Author: Rui Chen <email address hidden>
Date: Fri Mar 10 17:32:44 2017 +0800

    [Compute]Make column content readable for both human and machine

    Currently, we use utils.format_dict(), utils.format_list(),
    utils.format_list_of_dicts to make column value can be easy to read by
    human, but osc support to format the CLI output into several format,
    like: json, shell, csv, yaml, most of these should be understand by
    program and code, so keeping the column content as the original value
    make sense, like {u'name': u'RuiChen'} than name='RuiChen'

    The patch include all compute commands.

    Change-Id: I313a52f94895625e6045df870320840fee157759
    Implements: blueprint osc-formattable-columns
    Partial-Bug: #1538015
    Partial-Bug: #1538006