Unit test failure when buildnig debian package for 2.0.0

[Thomas Goirand]

Hi,

I get 3 failures when building the python-openstackclient package in Debian Jessie. Note that it does work perfectly in Sid, so I'm not sure what's going on.

======================================================================
FAIL: openstackclient.tests.test_shell.TestShellCli.test_shell_args_precedence
openstackclient.tests.test_shell.TestShellCli.test_shell_args_precedence
----------------------------------------------------------------------
_StringException: Empty attachments:
  stdout

stderr: {{{Region krikkit is not a valid region name for cloud megacloud. Valid choices are occ-cloud. Please note that region names are case sensitive.}}}

Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/mock/mock.py", line 1305, in patched
    return func(*args, **keywargs)
  File "openstackclient/tests/test_shell.py", line 680, in test_shell_args_precedence
    _shell.cloud.name,
AttributeError: 'OpenStackShell' object has no attribute 'cloud'

======================================================================
FAIL: openstackclient.tests.test_shell.TestShellCliEnv.test_shell_args_precedence_1
openstackclient.tests.test_shell.TestShellCliEnv.test_shell_args_precedence_1
----------------------------------------------------------------------
_StringException: Empty attachments:
  stdout

stderr: {{{Region occ-env is not a valid region name for cloud megacloud. Valid choices are occ-cloud. Please note that region names are case sensitive.}}}

Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/mock/mock.py", line 1305, in patched
    return func(*args, **keywargs)
  File "openstackclient/tests/test_shell.py", line 734, in test_shell_args_precedence_1
    _shell.cloud.name,
AttributeError: 'OpenStackShell' object has no attribute 'cloud'

======================================================================
FAIL: openstackclient.tests.test_shell.TestShellCliEnv.test_shell_args_precedence_2
openstackclient.tests.test_shell.TestShellCliEnv.test_shell_args_precedence_2
----------------------------------------------------------------------
_StringException: Empty attachments:
  stdout

stderr: {{{Region krikkit is not a valid region name for cloud megacloud. Valid choices are occ-cloud. Please note that region names are case sensitive.}}}

Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/mock/mock.py", line 1305, in patched
    return func(*args, **keywargs)
  File "openstackclient/tests/test_shell.py", line 775, in test_shell_args_precedence_2
    _shell.cloud.name,
AttributeError: 'OpenStackShell' object has no attribute 'cloud'

[Steve Martinelli (stevemar)]

We filed a similar bug to get our gate passing again: https://bugs.launchpad.net/python-openstackclient/+bug/1528926

os-client-config had a backwards incompatible change: https://github.com/openstack/os-client-config/commit/8fa55700b90e335e54cd459ea8a60578e8d27fc7

so I guess check that os-client-config is at least at level 1.13.1 ?

[Thomas Goirand (thomas-goirand)]

I was using version 1.14.0, so that's higher than what you just wrote.

[Thomas Goirand (thomas-goirand)]

Here's the full log if you want to check:

https://mitaka-jessie.pkgs.mirantis.com/job/python-openstackclient/10/consoleFull

This includes the version of each component if you look closely enough.

[Alexander Tsamutali (astsmtl)]

We got the same problem building stable/liberty package. #1528926 states that incompatible change was made to os-client-config. This change was based on 1.13.0, so I tried to run tests with 1.13.0 but got the same error. Then I tried 1.12.0 and with this version test succeeded.

[Steve Martinelli (stevemar)]

Looks like https://github.com/openstack/os-client-config/commit/8fa55700b90e335e54cd459ea8a60578e8d27fc7 needs to be backported to liberty for OCC and https://github.com/openstack/python-openstackclient/commit/d1311f9742ad93198b9ca72f47d51710e17ced38 needs to be backported to liberty for OSC

we're seeing this now in our stable branches too: https://review.openstack.org/#/c/258337/

[Thomas Goirand (thomas-goirand)]

FYI, rebuilding the latest version in Newton (ie: version 2.6.0), with os-client-config version 1.16.0, everything works (ie: not unit test error).

[Steve Martinelli (stevemar)]

thanks zigo, i'll mark this as invalid then, i doubt we want to waste resources looking at old errors.